issue-#79 bug fixes in StdTabViews

Locked

Should we merge topic branch issue-#79 with master?

Yes
7
88%
No
0
No votes
Abstain
1
13%
 
Total votes: 8

Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

issue-#79 bug fixes in StdTabViews

Post by Ivan Denisov »

This voting is about issue-#79:
http://redmine.blackboxframework.org/issues/79
http://forum.blackboxframework.org/view ... f=40&t=314

Few bugs in StdTabViews were fixed:
1. View.SetIndex needs to call 'Neutralize' in order to prevent locking some controls (in particular list boxes) in the nested form view. Reported by luowy, 2015-10-28.
2. View.Neutralize needs to test the embedded view for NIL. Refers to oberoncore B19.
3. TrapCleaner.Cleanup needs to set t.v.tc to NIL before calling t.v.Reset in order to prevent calling PopTrapCleaner and thereby emptying the trap stack. Refers to oberoncore B20.

Also the restoring of focus item which not empty was optimized.

The suggested differences:
http://redmine.blackboxframework.org/pr ... f&type=sbs

The BlackBox version for testing:
http://blackboxframework.org/unstable/i ... a1.378.zip
luowy
Posts: 234
Joined: Mon Oct 20, 2014 12:52 pm

Re: issue-#79 bug fixes in StdTabViews

Post by luowy »

SetItem is no need changed, in my opinion.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#79 bug fixes in StdTabViews

Post by Ivan Denisov »

luowy wrote:SetItem is no need changed, in my opinion.
That is one of optimisation points. Inside the SetItem procedure label not changing, but coping to SetItemOp record, so it should not be copied before entering the SetItem. Now without IN parameter it is coping twice. Any array without IN or VAR parameter coping for preventing of been changed.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#79 bug fixes in StdTabViews

Post by Ivan Denisov »

This voting united many fixes. That is not problem to vote separately about SetNofTabs, so I moved this discussion to separate topic for you can continue when I lock this topic.

The voting is finished and the resulting version is:
http://blackboxframework.org/unstable/m ... a1.386.zip
http://blackboxframework.org/unstable/m ... -setup.exe
Locked