For the issue see https://redmine.blackboxframework.org/issues/147.
For the discussion see viewtopic.php?f=41&t=586.
For the diffs see https://redmine.blackboxframework.org/p ... bd90a41bd0.
The Strings file also includes the changes from issue 139.
Issue-#147 Adding a "Mod1" function to Math/SMath
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Robert, why did you remove the empty line at the end of System/Rsrc/Strings?
Please leave it in place.
It serves to group the added entries when adding the build information.
Note: You will still get a merge conflict with System/Rsrc/Strings.
- Josef
Please leave it in place.
It serves to group the added entries when adding the build information.
Note: You will still get a merge conflict with System/Rsrc/Strings.
- Josef
- DGDanforth
- Posts: 1061
- Joined: Tue Sep 17, 2013 1:16 am
- Location: Palo Alto, California, USA
- Contact:
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
I don't like the name Mod1.
By symmetry there should be two functions
FracF (for Floor)
FracT (for Trunc)
For backwards compatibility we keep Frac
but should add the other name FracF.
-Doug
By symmetry there should be two functions
FracF (for Floor)
FracT (for Trunc)
For backwards compatibility we keep Frac
but should add the other name FracF.
-Doug
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
I have changed my vote to Abstain until the missing blank line issue is sorted out.
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Also the naming issue brought up by Doug needs further discussion.
I think the voting has been created too early.
We should continue the discussion in the issue topic.
- Josef
I think the voting has been created too early.
We should continue the discussion in the issue topic.
- Josef
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Vote cancelled.