Issue #21: Caret blink freeze

Locked

Shall the Center implement an Issue #21: Caret blink freeze solution?

ABSTAIN
0
No votes
YES
7
100%
NO
0
No votes
 
Total votes: 7

User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Issue #21: Caret blink freeze

Post by DGDanforth »

This vote is to take into account the freezing of the caret when the elapse time from last Windows start exceeds 49.7 days.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #21: Caret blink freeze

Post by Ivan Denisov »

Doug, this suggested fixes are not controversial but supplementing. We should not choose between them, but apply both...

Also, better if we have branch with trial version before voting. I will try to do it soon.

Chris, Louwy, please, can you give some comments here.
luowy
Posts: 234
Joined: Mon Oct 20, 2014 12:52 pm

Re: Issue #21: Caret blink freeze

Post by luowy »

I think we should voting for changing the type of the Controllers.TickMsg.tick,not the Kernel.Time implementation.

the "Caret blink freeze" issue after 49.7days can be resolved by changing the type of Controllers.TickMsg.tick from INTEGER to LONGINT and use the Services.Tick instead of WinApi function.


the suggestion of Chris is more about the Kernel.Time's implementation. using Services.Tick is more suitable than WinApi in here.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #21: Caret blink freeze

Post by Ivan Denisov »

I made branch for issue #21:
http://blackboxframework.org/unstable/issue-%2321/
https://github.com/BlackBoxCenter/black ... ssue-%2321
http://redmine.blackboxframework.org/pr ... ssue-%2321

I have included Louwy fix.

Chris, did I understand right, that you are suggesting additional issue and separate from this?
cfbsoftware
Posts: 204
Joined: Wed Sep 18, 2013 10:06 pm
Contact:

Re: Issue #21: Caret blink freeze

Post by cfbsoftware »

It could be treated as a separate issue if preferred. Note that the use of GetTickCount64 requires the software to be running on Windows Vista or later. The question to ask first is whether the Center version of BlackBox is still going to be tested and supported on Windows XP.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #21: Caret blink freeze

Post by Ivan Denisov »

Doug, please, change the voting options. Or can I help you? We will make new issue for Chris suggestion. It will be related with support of Win XP. We need some more discussion. But we are ready to vote for Luowy fix.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Issue #21: Caret blink freeze

Post by DGDanforth »

Chris,
Darn, I missed that requirement. I would not have put that to a vote if I had known.
I am running on XP.
cfbsoftware wrote:It could be treated as a separate issue if preferred. Note that the use of GetTickCount64 requires the software to be running on Windows Vista or later. The question to ask first is whether the Center version of BlackBox is still going to be tested and supported on Windows XP.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Issue #21: Caret blink freeze

Post by DGDanforth »

Ivan,
Yes, please change the vote to YES or NO on luowy's solution,
-Doug
Ivan Denisov wrote:Doug, please, change the voting options. Or can I help you? We will make new issue for Chris suggestion. It will be related with support of Win XP. We need some more discussion. But we are ready to vote for Luowy fix.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #21: Caret blink freeze

Post by Ivan Denisov »

DGDanforth wrote:Ivan,
Yes, please change the vote to YES or NO on luowy's solution
Done.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #21: Caret blink freeze

Post by Ivan Denisov »

The voting is finished according "short circuit" rule.

I applied changes to master branch after marking the fix at the top of each document as Josef mentioned in bug discussion.

The resulting version is:
http://blackboxframework.org/unstable/m ... a1.034.zip
Locked