issue#-189 improving the treatment of sign in Math/SMath

Locked

Should we incorporate these changes into the master?

Poll ended at Sun Jul 08, 2018 9:11 am

Yes
6
100%
No
0
No votes
Abstain
0
No votes
 
Total votes: 6

User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue#-189 improving the treatment of sign in Math/SMath

Post by Josef Templ »

This is a poll for merging the changes of issue-#189 into the master branch.
It adds the functions CopySign and SignBit to Math/SMatch and fixes the treatment of
negative zero in Sign(), SinH(), TanH, etc.

The complete diffs are https://redmine.blackboxframework.org/p ... 406d97e082.

A test version is available under http://blackboxframework.org/unstable/i ... 1.1053.zip.

Please cast your votes.

- Josef
Last edited by Josef Templ on Thu Jul 05, 2018 7:41 pm, edited 1 time in total.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue#-189 improving the treatment of sign in Math/SMath

Post by Robert »

In the suggested procedure ArcTan2 a bit of commented out code has been left in grey. We might wish to change that to default colour.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue#-189 improving the treatment of sign in Math/SMath

Post by Josef Templ »

done.

- Josef
Locked