issue-#155 Clean the sources from old commented realisations

Post Reply
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

issue-#155 Clean the sources from old commented realisations

Post by Ivan Denisov »

I suggest to clean some of the commented code in the sources of BlackBox.

Some of this commented code should not be deleted, because it makes existing code easier to understand.

However many of comments just providing the mess. The example is Dialog module:

Code: Select all

		NEW(showHook); Dialog.SetShowHook(showHook);
(*
		Hooks.showParamMsg := ShowParamMsg;
		Hooks.showParamStatus := ShowParamStatus;
*)

		NEW(dialogHook); Dialog.SetGetHook(dialogHook);
(*
		Hooks.getOK := GetOK;
		Hooks.getIntSpec := GetIntSpec0;
		Hooks.getExtSpec := GetExtSpec0;
		Hooks.getColor := ColorDialog0;
*)

(*
		Sequencers.GetIntSpec := GetIntSpec;
		Sequencers.GetExtSpec := GetExtSpec;
*)
		NEW(getSpecHook); Views.SetGetSpecHook(getSpecHook);

		HostFiles.MapParamString := Dialog.MapParamString;

		NEW(datesHook); Dates.SetHook(datesHook);
(*
		Hooks.getTime := GetTime;
		Hooks.dateToString := DateToString;
		Hooks.timeToString := TimeToString
*)
		NEW(languageHook); Dialog.SetLanguageHook(languageHook); Dialog.ResetLanguage;
		NEW(extCallHook); Dialog.SetExtCallHook(extCallHook);
		hideExtRunWindow := FALSE
	END Init;
Post here your suggestions, please.
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: issue-#155 Clean the sources from old commented realisat

Post by Zinn »

What's about this topic?
Does it make sense?
Or is it cancelled?
- Helmut
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#155 Clean the sources from old commented realisat

Post by Josef Templ »

For the Dialog module it would be good to clean it up as suggested by Ivan, I think.
Going over ALL modules is a lot of work and it has the potential to create merge conflicts with other
issues that pop up in the meantime.
If it is done, it should be done when there are no other pending issues and
it should be done quickly.
My guts feeling is that it is not worth the effort to go over all modules.

- Josef
Post Reply