issue-#152 Documentation errors in CommStreams and Dialog
Documentation errors in CommStream & Dialog
1. CommStreams
In the line
PROCEDURE (l: Listener) LocalAdr
is missing (): Adr
PROCEDURE (l: Listener) LocalAdr (): Adr
2. Dialog
PROCEDURE ShowParamMsg (IN str, p0, p1, p2: ARRAY OF CHAR)
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
On both procedures the Pre definition
Pre
LEN(str$) # NIL 20
is wrong. Right is
Pre
str # "" 20
- Helmut
In the line
PROCEDURE (l: Listener) LocalAdr
is missing (): Adr
PROCEDURE (l: Listener) LocalAdr (): Adr
2. Dialog
PROCEDURE ShowParamMsg (IN str, p0, p1, p2: ARRAY OF CHAR)
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
On both procedures the Pre definition
Pre
LEN(str$) # NIL 20
is wrong. Right is
Pre
str # "" 20
- Helmut
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: Documentation errors in CommStream & Dialog
Right.Zinn wrote:1. CommStreams
In the line
PROCEDURE (l: Listener) LocalAdr
is missing (): Adr
PROCEDURE (l: Listener) LocalAdr (): Adr
- Helmut
Keyword PROCEDURE appears twice for ShowMsg.Zinn wrote: 2. Dialog
PROCEDURE ShowParamMsg (IN str, p0, p1, p2: ARRAY OF CHAR)
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
On both procedures the Pre definition
Pre
LEN(str$) # NIL 20
is wrong. Right is
Pre
str # "" 20
- Helmut
I cannot find "LEN(str$) # NIL 20" in 1.7.1.
Are you referring to your CPC version?
- Josef
Re: Documentation errors in CommStream & Dialog
Josef, your are right. I miss the last change in Dialog. Now this part of Dialog is identical
- Helmut
- Helmut
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
issue-#152 Documentation errors in CommStreams and Dialog
I have created issue-#152 for fixing the docu errors reported by Helmut.
For the issue see https://redmine.blackboxframework.org/issues/152.
For the changes see https://redmine.blackboxframework.org/p ... 09ddc6ad20.
- Josef
For the issue see https://redmine.blackboxframework.org/issues/152.
For the changes see https://redmine.blackboxframework.org/p ... 09ddc6ad20.
- Josef
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#152 Documentation errors in CommStreams and Dialo
I found one extra line
in System/Docu/Controllers at the end of the text.
Can we join this this issue with removing of this extra line?
Code: Select all
PROCEDURE SetCurrentPath (target: BOOLEAN)
Can we join this this issue with removing of this extra line?
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#152 Documentation errors in CommStreams and Dialo
joined.
See diffs at https://redmine.blackboxframework.org/p ... 26aaab4f33.
It turned out to be a little more than just removing the replicated line.
- Josef
See diffs at https://redmine.blackboxframework.org/p ... 26aaab4f33.
It turned out to be a little more than just removing the replicated line.
- Josef
Re: issue-#152 Documentation errors in CommStreams and Dialo
Is this ready for voting?
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#152 Documentation errors in CommStreams and Dialo
I think, yes.Robert wrote:Is this ready for voting?
Re: issue-#152 Documentation errors in CommStreams and Dialo
You correct in the Docu of Dialog the line
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowMsg (IN str: ARRAY OF CHAR)
but you forgot to correct the line
PROCEDURE ShowStatus PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowStatus (IN str: ARRAY OF CHAR)
- Helmut
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowMsg (IN str: ARRAY OF CHAR)
but you forgot to correct the line
PROCEDURE ShowStatus PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowStatus (IN str: ARRAY OF CHAR)
- Helmut
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#152 Documentation errors in CommStreams and Dialo
I made this small fixZinn wrote:You correct in the Docu of Dialog the line
PROCEDURE ShowMsg PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowMsg (IN str: ARRAY OF CHAR)
but you forgot to correct the line
PROCEDURE ShowStatus PROCEDURE (IN str: ARRAY OF CHAR)
to
PROCEDURE ShowStatus (IN str: ARRAY OF CHAR)
- Helmut
https://redmine.blackboxframework.org/p ... 0e7fc24030
I think, that there is no reason for revote, because we already voted for this.
The version with the fix:
http://blackboxframework.org/unstable/m ... a1.837.zip