Page 1 of 1
Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Sun Feb 26, 2017 9:42 am
by Robert
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Mon Feb 27, 2017 8:38 am
by Josef Templ
Robert, why did you remove the empty line at the end of System/Rsrc/Strings?
Please leave it in place.
It serves to group the added entries when adding the build information.
Note: You will still get a merge conflict with System/Rsrc/Strings.
- Josef
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Mon Feb 27, 2017 10:37 am
by DGDanforth
I don't like the name Mod1.
By symmetry there should be two functions
FracF (for Floor)
FracT (for Trunc)
For backwards compatibility we keep Frac
but should add the other name FracF.
-Doug
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Mon Feb 27, 2017 2:48 pm
by Robert
I have changed my vote to Abstain until the missing blank line issue is sorted out.
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Mon Feb 27, 2017 3:20 pm
by Josef Templ
Also the naming issue brought up by Doug needs further discussion.
I think the voting has been created too early.
We should continue the discussion in the issue topic.
- Josef
Re: Issue-#147 Adding a "Mod1" function to Math/SMath
Posted: Mon Feb 27, 2017 5:37 pm
by Robert
Vote cancelled.