Page 5 of 8
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Mon Nov 07, 2016 8:44 pm
by Robert
See the diffs:
http://redmine.blackboxframework.org/pr ... 65730f0320
This Git stuff is quite exciting - you never know what is going to happen next!
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Tue Nov 08, 2016 10:50 am
by Zinn
In module DevBrowser there is the yoyo effect between uft8 - str - utf8 in the procedure ShowInterface
GetQualIdent(mod, ident, t);
Kernel.Utf8ToString(mod, modStr, res);
DevReferences.ResolveImportAlias(modStr, t);
Kernel.StringToUtf8(modStr, mod, res);
We should change the procedure ShowInterface back to its 1.7 original version
and after the command GetQualident delete the line CheckModName(mod, t);
How to insert the new functionality?
Just insert into the procedure GetQualident the new line ResolveImportAlias before the translation to utf8.
DevReferences.ResolveImportAlias(s.string, t);
Kernel.StringToUtf8(s.string, mod, res);
The advantage is that the forgotten change in procedure ShowCodeFile is also done via GetQualident.
- Helmut
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Tue Nov 08, 2016 11:04 am
by Robert
Seems like a good idea?
Zinn wrote:... the forgotten change in procedure ShowCodeFile ...
Actually I didn't technically
forget ShowCodeFile, I ignored it! I did a "Search in Sources" and it is not used, and I couldn't (in 30 seconds) find where it is called, so I gave up looking.
1 - Where is it used? I need to know to check any changes.
2 - Should we consider adding a Menu Command "Search in Rsrc"? Useful options would be to list all files in an installation, or to list / select all Controls in a given Form. "Search in Menus" could also be useful.
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Tue Nov 08, 2016 2:45 pm
by Josef Templ
It's probably the simplest and cleanest to reconstruct the branch from zero.
It takes only a few seconds.
The branch on github now has a suspicious Merge commit.
Something has been done that is not straight-forward.
1. Throw away the branch in github. Click on '7 branches', click the trash icon on the branch to remove.
2. Create a new branch with the same name as the removed one.
3. Clone the newly created branch into a new local directory.
4. Copy over the changed files.
5. Make a single commit to the new local repository.
6. Push back the new local repository.
- Josef
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Wed Nov 09, 2016 8:05 pm
by Robert
I have incorporated Helmut's suggestions, including testing the updated
ShowCodeFile Command. This meant creating my own test harness, as I still can't find anywhere where it is currently used.
Josef Templ wrote:It takes only a few seconds.
...
1. Throw away the branch in github. Click on '7 branches', click the trash icon on the branch to remove.
I have spent several times 'a few minutes' and can't find '7 branches'. I need a clue. Is this on my PC, or some web page somewhere?
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Thu Nov 10, 2016 5:40 am
by Ivan Denisov
Robert wrote:... some web page somewhere?
After you delete this branch you need to update you local repository. However be sure that you backed up the project files for the Josef plan.
I find that this manipulations with cleaning branches very hard. Better someone help you... me or Josef.
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Thu Nov 10, 2016 8:20 pm
by Robert
I think I have now managed to follow Josef's suggestions. Anyway, the new diff is
http://redmine.blackboxframework.org/pr ... 65730f0320
Hopefully nothing got lost on the way.
So, again, ready for test / comment.
Thanks Ivan. I know it is easier for you guys to do this than teach me, but I hope the effort of learning for myself will pay off in the long run. I eventually found that page above:
Browser -> Favorites -> BlackBox Framework Centre -> Issues tracker -> Overview ->
https://github.com/BlackBoxCenter/blackbox
There is probably a more direct way?
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Fri Nov 11, 2016 7:54 am
by Ivan Denisov
Robert wrote:There is probably a more direct way?
Here it is
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Fri Nov 11, 2016 9:05 am
by Robert
I must have tried 50 links on that page, with names that mean nothing to me like "Gist".
In retrospect I guess it is obvious I should have tried the big blue "blackbox" near the bottom of the page.
Anyway, what do people think about the actual issue here? I have posted a link to the diffs, but there does not seem to be a new "unstable" .zip. The last one is dated 7 November, but the code was updated 10 November. Have I made another process error?
Re: issue-#140 Unwrapping IMPORT aliasses
Posted: Fri Nov 11, 2016 12:18 pm
by Ivan Denisov
Robert wrote: Have I made another process error?
I studied whats happened... build process sticked. I do not know why.
I just killed the process and it starts again without errors. That's the last build for #140.
http://blackboxframework.org/unstable/i ... a1.732.zip