Page 1 of 1
issue-#132 Unwanted characters in the definition... Refs:#19
Posted: Wed Sep 28, 2016 6:25 pm
by Ivan Denisov
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Thu Sep 29, 2016 11:44 pm
by DGDanforth
I can verify that
Code: Select all
DEFINITION Foo;
TYPE
Βασε = EXTENSIBLE RECORD END;
Εχτ = RECORD (Βασε 00X 懨 00X 00X ) END;
PROCEDURE Do;
END Foo.
It appears there are 4 characters added.
-Doug
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Sat Oct 01, 2016 3:58 pm
by Zinn
It is a very strange error.
Change in the PROCEDURE ProperString (s: ARRAY OF SHORTCHAR); of MODULE DevBrowser;
the line
i := 0; WHILE (s # 0X) & (s # "^") DO global.out.WriteChar(str); INC(i) END
to
i := 0; WHILE (i < LEN(str$)) & (s # 0X) & (s # "^") DO global.out.WriteChar(str); INC(i) END
and it works.
Why does not work the compare s # 0X ?
- Helmut
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Sat Oct 01, 2016 6:52 pm
by DGDanforth
Partial answer.
SHORTCHAR can not hold a Uni char.
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Sun Oct 02, 2016 6:47 am
by Zinn
Now I see the error. I must be blind.
The correct line is
i := 0; WHILE (str # 0X) & (str # "^") DO global.out.WriteChar(str); INC(i) END
Helmut
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Sun Oct 02, 2016 3:07 pm
by Ivan Denisov
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Mon Oct 03, 2016 9:37 am
by Josef Templ
The fix looks fine to me.
Note: We also need to update appbuild/AppVersion.txt to "1.7.1-a1".
- Josef
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Thu Oct 06, 2016 1:30 pm
by Ivan Denisov
I have changed the app version
http://blackboxframework.org/unstable/i ... a1.698.zip
Doug, this issue is tested and ready for voting.
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Thu Oct 06, 2016 1:39 pm
by Josef Templ
agree
Re: issue-#132 Unwanted characters in the definition... Refs
Posted: Thu Oct 06, 2016 7:48 pm
by DGDanforth
Vote has been created.