Page 1 of 1

issue-#127 ShowRange does not clear the auto-scroll range

Posted: Fri Sep 02, 2016 6:48 pm
by Josef Templ
I have created issue-#127 for the StdFolds bug observed by Doug.
See http://redmine.blackboxframework.org/issues/127.

Actually this is not related to StdFolds but has first been observed when using the new folds.
The explanation of the bug is here: http://forum.blackboxframework.org/view ... t=20#p4626.

A first proposal for a fix is in the topic branch.
See the diffs at http://redmine.blackboxframework.org/pr ... bffe12c4b9.

A text view simply forwards the PositionMsg to its controller, which then clears the auto scroll range.

However, it needs a careful review and tests.
This has some potential for surprises but so far I have not experienced any.
I mean, it could be that the "buggy" behavior was used somewhere and would now be changed unintentionally.

Note: Currently the fix ignores msg.focusOnly. I don't know if this is a problem.
This is the major open question, I believe.

- Josef

Re: issue-#127 ShowRange does not clear the auto-scroll rang

Posted: Fri Sep 02, 2016 11:47 pm
by DGDanforth
Good going Josef and luowy!
I just tested the changes and that works for me.
-Doug

Re: issue-#127 ShowRange does not clear the auto-scroll rang

Posted: Sat Sep 03, 2016 2:56 am
by Ivan Denisov
Tested this version
http://blackboxframework.org/unstable/i ... c1.661.zip
works well.

I think that this issue is ready for voting.

Re: issue-#127 ShowRange does not clear the auto-scroll rang

Posted: Sat Sep 03, 2016 7:07 am
by Josef Templ
I have removed the explicit forwarding of the PositionMsg from TextViews because
this is done anyway in TextViews.ShowRange (via broadcast). TextViews is no longer changed.

I also have added a focus check now in TextControllers when handling the PositionMsg.

Works as before for our test case.

For the total diff see http://redmine.blackboxframework.org/pr ... bffe12c4b9.

- Josef

Re: issue-#127 ShowRange does not clear the auto-scroll rang

Posted: Sat Sep 03, 2016 7:17 am
by DGDanforth
Simpler is better.
Works for me.
-Doug