Fold expansion is wrong when clicked on |+>

User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Fold expansion is wrong when clicked on |+>

Post by DGDanforth »

Folks,
When I click on |+> the caret is placed at the bottom of the expanded text.
It should be placed at the top of the expanded text.
-Doug
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Fold expansion is wrong when clicked on |+>

Post by Ivan Denisov »

I am not able to reproduce this with a caret, but I think that you mean scrolling to the bottom. I agree, that this is annoying.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Fold expansion is wrong when clicked on |+>

Post by DGDanforth »

Ivan Denisov wrote:I am not able to reproduce this with a caret, but I think that you mean scrolling to the bottom. I agree, that this is annoying.
Yes, I mean scrolling to the bottom.

If you have a very long fold then it is more than annoying to have to scroll back up to the top.
Wasn't that the behavior in 1.6?

I just did a test in 1.6 by copying Guided Tour to a new file, selected all, and then created a fold.
Clicking on the left => shows the top. Clicking on the <= shows the bottom.
That is the correct behavior.

Some where we have introduced this bug.

-Doug
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Fold expansion is wrong when clicked on |+>

Post by Ivan Denisov »

We can analyze all the changes done with Folds.

http://redmine.blackboxframework.org/pr ... rev=master

It should be somewhere here.

http://redmine.blackboxframework.org/pr ... 50a271f168
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Fold expansion is wrong when clicked on |+>

Post by Ivan Denisov »

Doug, I downloaded 1.6 and does not see "correct behavior". All like in build 650...
Bernhard
Posts: 68
Joined: Tue Sep 17, 2013 6:56 am
Location: Munich, Germany

Re: Fold expansion is wrong when clicked on |+>

Post by Bernhard »

In 1.6rc6 switching the fold content by clicking on left fold positions the cursor right after the switched left fold, clicking on the right mark postions before the switched fold mark.

In 1.7-rc1 (b606): clicking left fold positions exactly the same way as clicking right fold: Cursor is just before right fold. This occurs only, if the other state is empty. If it contains at least one character (e.g. blank) it behaves like 1.6.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Fold expansion is wrong when clicked on |+>

Post by DGDanforth »

This occurs only, if the other state is empty. If it contains at least one character (e.g. blank) it behaves like 1.6.
What do you mean by "state"?
luowy
Posts: 234
Joined: Mon Oct 20, 2014 12:52 pm

Re: Fold expansion is wrong when clicked on |+>

Post by luowy »

Doug,
would you please post a "bug" file to us? it is more better than explaination with words,I think.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Fold expansion is wrong when clicked on |+>

Post by DGDanforth »

If one folds a large document then
BB1.6 clicking left and right shows different views (correct)
BB1.7 clicking left and right shows same view (wrong)
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Fold expansion is wrong when clicked on |+>

Post by DGDanforth »

BB1.7rc1 Fold of Guided Tour
BB1.7rc1 Fold of Guided Tour
BB1.6 fold of Guided Tour
BB1.6 fold of Guided Tour
luowy wrote:Doug,
would you please post a "bug" file to us? it is more better than explaination with words,I think.
Post Reply