Page 1 of 3
issue-#19 showing unicode identifiers with show sources
Posted: Sat Jul 02, 2016 5:17 am
by Ivan Denisov
DevReferences.SearchIdent still contains some ASCII assumptions
Code: Select all
(* search legal start symbol *)
WHILE ~r.eot & ((ch < "A") OR (ch > "Z") & (ch # "_") & (ch < "a") OR (ch > "z")) DO
INC(beg); r.ReadChar(ch)
END;
It is leading to the bug, that when you trying to find some unicode procedure with "Source" pop up menu BlackBox just opening file and doesn't skip to procedure position.
So this code should be replaced with:
Code: Select all
(* search legal start symbol *)
WHILE ~r.eot & ~ Kernel.IsAlpha(ch) DO
INC(beg); r.ReadChar(ch)
END;
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sat Jul 02, 2016 5:28 am
by Ivan Denisov
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sat Jul 02, 2016 6:04 am
by Josef Templ
Ivan, why don't you use Strings.IsIdentStart?
The comment suggests that this loop is for looking up the start of an identifier.
- Josef
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sat Jul 02, 2016 6:07 am
by Ivan Denisov
Josef Templ wrote:Ivan, why don't you use Strings.IsIdentStart?
The comment suggests that this loop is for looking up the start of an identifier.
- Josef
You right. I simply forgot about Strings.IsIdentStart. I will change and test today.
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sat Jul 02, 2016 4:03 pm
by Ivan Denisov
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sun Jul 03, 2016 5:20 pm
by Josef Templ
In the changes fold, there are now two lines related to issue-#19.
One reads: "the bug in SearchIdent fixed".
This must be removed because this fix is about
Unicode support for Component Pascal identifiers as listed anyway.
There is no other bug as far as I can see.
- Josef
Re: issue-#19 showing unicode identifiers with show sources
Posted: Sun Jul 03, 2016 5:58 pm
by Ivan Denisov
Ok
Now this is very simple fix
http://redmine.blackboxframework.org/pr ... d4a5a7ffc8
I think it is very clear and ready for voting.
Re: issue-#19 showing unicode identifiers with show sources
Posted: Mon Jul 04, 2016 12:33 pm
by Josef Templ
agree.
Re: issue-#19 showing unicode identifiers with show sources
Posted: Mon Jul 04, 2016 7:00 pm
by Zinn
Have we a similar problem in module HostMenus about hotkey selection?
- Helmut
Re: issue-#19 showing unicode identifiers with show sources
Posted: Mon Jul 04, 2016 9:12 pm
by Josef Templ
I am afraid, yes.
Also in DevProfiler.
- Josef