Page 2 of 4

Re: Converters

Posted: Wed Jun 22, 2016 1:11 am
by DGDanforth
Josef Templ wrote: I also don't see any need for an id field within a Converter.
Right, the id is not needed.

Re: Converters

Posted: Wed Jun 22, 2016 1:20 am
by DGDanforth
Josef Templ wrote:To me a simple and meaningful extension would be to add two procedures:

PROCEDURE RegisterEx(..., OUT c: Converter);
PROCEDURE Unregister(c: Converter);

where RegisterEx can be used for registering a temporarily used converter,
i.e. one that is subject to Unregister at a later time.
Such a case is typical when developing a new converter because
multiple edit-compile-load-register cycles can be involved.
The only slight problem I see with "PROCEDURE Unregister(c: Converter);" is that the converter 'c' may reside in the middle of the list and hence
a recursive removal of 'c' would be needed.

With OpenRegistry and CloseRegistry all converters added after the open would be removed by the close.

Re: Converters

Posted: Wed Jun 22, 2016 1:26 am
by DGDanforth
In (My)Converters I just added a few lines of code to transform the 'list' into a 'set'.
That entailed creating the hidden procedure 'Equal(c1, c2)' which returns true if the
converters are equal on a field by field comparison.

I did that because in old code I found that I had added a converter twice and it showed
up twice in the 'Files of type' list.

-Doug

Re: Converters

Posted: Wed Jun 22, 2016 9:52 am
by Josef Templ
Changing next- to next* is a nice idea.
It gives a large amount of freedom for a minimal amount of change.

- Josef

Re: Converters

Posted: Wed Jun 22, 2016 10:00 am
by DGDanforth
Josef Templ wrote:Changing next- to next* is a nice idea.
It gives a large amount of freedom for a minimal amount of change.

- Josef
Yes, one can "cut" the list at an arbitrary point or even reorder it.
-Doug

Re: Converters

Posted: Wed Aug 03, 2016 4:57 am
by Ivan Denisov
Josef Templ wrote:Changing next- to next* is a nice idea.
It gives a large amount of freedom for a minimal amount of change.
It seems to be very simple feature. Should we change status to beta if we will include this issue in 1.7 ?

Re: Converters

Posted: Wed Aug 03, 2016 5:48 am
by DGDanforth
Ivan Denisov wrote:
Josef Templ wrote:Changing next- to next* is a nice idea.
It gives a large amount of freedom for a minimal amount of change.
It seems to be very simple feature. Should we change status to beta if we will include this issue in 1.7 ?
Do you mean step back from release candidate to beta?
We can just try it as unstable and see how people use and like it.
-Doug

Re: Converters

Posted: Thu Aug 04, 2016 5:38 pm
by Ivan Denisov
DGDanforth wrote:Do you mean step back from release candidate to beta?
We can just try it as unstable and see how people use and like it.
So let's also leave it for 1.8 unstable.

Re: Converters

Posted: Fri Aug 05, 2016 1:25 am
by DGDanforth
Agreed.

Re: Converters

Posted: Fri Aug 05, 2016 8:18 am
by Josef Templ
Well, 1.8 means binary incompatible to 1.7.
1.7.1, 1.7.2 etc. means binary compatible (bug fixes, minor extensions).
The next version should not be 1.8 but 1.7.1.
And, no, I don't want to work on multiple versions in parallel.
This complicates things significantly.

To summarize, I don't feel very comfortable with the idea of having 1.8 shortly after 1.7.
1.7.x must be a stable version that exists for quite some time.

The Converters change would not be binary compatible.
If we already agree that we want to have it, it should be done in 1.7.

- Josef