Converters (merged with Converters Docu)

User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Converters (merged with Converters Docu)

Post by DGDanforth »

Converters.Converter^ is not consistently imported
Hmm, does that mean the framework is not automatically recompiled when a pull, merge is performed?

There are 28 files in the framework that use Converters
28 Files found
263 Files searched
14 Dirs searched
0.562 Time (sec)
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Converters (merged with Converters Docu)

Post by Ivan Denisov »

DGDanforth wrote:
Converters.Converter^ is not consistently imported
Hmm, does that mean the framework is not automatically recompiled when a pull, merge is performed?
Last version works fine.
http://blackboxframework.org/unstable/m ... c1.621.zip

Remove Code and Sym folders from your extra subsystems and recompile them.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Converters (merged with Converters Docu)

Post by Josef Templ »

DGDanforth wrote:
Converters.Converter^ is not consistently imported
Hmm, does that mean the framework is not automatically recompiled when a pull, merge is performed?
[/quote]

master is recompiled automatically after a merge.
It may take some time (5 minutes or so) after a merge until you can be sure that
the latest build is available for download.
The buildlog can be consulted for finding out if it is available.

Your local installation is not affected in any way.
You must recompile everything locally or you download and install the latest master build.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Converters Docu

Post by Josef Templ »

DGDanforth wrote:We forgot to change the documentation for Converters so I just did that.
I did a clone, modified docu, a commit, and a push. Worked.

Now I have forgotten whether it is necessary to do a second pull request for issue-#122.
Is it?
-Doug
I thought that this is an experimental feature and did not change the docu intentionally.
But it is also OK for me to change it.

After you push changes to issue-#122 you have to create a new pull request for merging with master.

- Josef
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Converters (merged with Converters Docu)

Post by DGDanforth »

I have recompiled about 80 modules that use Converters and, so far, everything works.

Josef, I may have created a mess by changing Converters so why don't we wait a bit
until others have had a chance to use it before doing 1.7 final release.

-Doug
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Converters (merged with Converters Docu)

Post by Ivan Denisov »

I made one test for `Converters.list.next := NIL` and see that this not crashes BlackBox :)

I do not think that many people will test this feature. So let's wait a week and release stable version.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Converters (merged with Converters Docu)

Post by Josef Templ »

DGDanforth wrote:I have recompiled about 80 modules that use Converters and, so far, everything works.

Josef, I may have created a mess by changing Converters so why don't we wait a bit
until others have had a chance to use it before doing 1.7 final release.

-Doug
I didn't notice any mess.
What exactly do you mean?
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Converters (merged with Converters Docu)

Post by DGDanforth »

Josef Templ wrote:
I didn't notice any mess.
What exactly do you mean?
I mean that a lot of personal files (may) need to be recompiled.

-Doug
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Converters (merged with Converters Docu)

Post by DGDanforth »

Here is one reason why the Converters documentation was misleading.
(*
Insert into the PROCEDURE Setup* of the MODULE System/Mod/Config.odc the following lines:
Converters.Register("CocoConv.ImportAtg", "CocoConv.ExportAtg", "TextViews.View", "atg", {});
Converters.Register("CocoConv.ImportFrm", "CocoConv.ExportFrm", "TextViews.View", "frm", {});
Compile the modified module and restart BlackBox.

Note: If you get a trap at menu File->Open then you have to many Converters in Setup.
Overflow in string space. All converter names together must be less then 512 characters.

The file Rsrc.odc can have the following entry:
STRINGS
CocoConv.ImportAtg Coco/R Attributed Grammar docu/text
CocoConv.ExportAtg Coco/R Attributed Grammar
CocoConv.ImportFrm Coco/R Frame docu/text
CocoConv.ExportFrm Coco/R Frame
*)
It is not necessary to modify the Config file to use Coco. One only needs to "install" the Coco converters from any module.
Much nicer with that new (to me and I believe others) understanding.
-Doug
Post Reply