issue-#113 XhtmlExporter bug with StdLinks.Target

[Josef Templ]

In BeginPara it would be simple to also support the "lead" attribute of text rulers.
It would look like:

Code: Select all

			IF e.currentRuler.style.attr.lead > 0 THEN
				Strings.IntToString(e.currentRuler.style.attr.lead DIV Fonts.point, str);
				IF attr[0] # 0X THEN attr := attr + " " END;
				attr := attr + "margin-top: " + str$ + "pt;"
			END;

Unfortunately the line spacing is not so simple.

The handling of non-breaking-spaces also has/had a bug.
It outputs a normal (breaking) space unless it is not the first space in a sequence of spaces.
A correct form IMHO would be:

Code: Select all

				IF ch = " " THEN
					IF e.afterSpace THEN e.wr.Data(" ") ELSE e.wr.Data(" "); e.afterSpace := TRUE END
				ELSIF (ch = TextModels.nbspace) OR (ch = TextModels.digitspace) THEN
					e.wr.Data(" "); e.afterSpace := FALSE

- Josef

[Ivan Denisov]

Added this changes. Agree that such spaces parsing is more correct.
http://blackboxframework.org/unstable/i ... b1.538.zip

[Zinn]

Another change may be to use the default font instead of Arial in MODULE XhtmlExporter

Code: Select all

	VAR
		defaultTypeface: Fonts.Typeface;
		defaultSize: INTEGER;
...
	BEGIN
		defaultTypeface := Fonts.dir.Default().typeface;
		defaultSize := Fonts.dir.Default().size;

- Helmut

[Ivan Denisov]

Another change may be to use the default font instead of Arial in MODULE XhtmlExporter

It is a problem to get default typeface name.

Fonts.dir.Default().typeface is "*";

I anybody find how to get default typeface it will be very useful.

[luowy]

Fonts.dir.Default().typeface is "*";

cast and use HostFonts.Font.alias;

Code: Select all

MODULE ObxFonts;
	IMPORT Fonts, HostFonts, Log := StdLog;
	
	
	PROCEDURE Do* ();
		VAR typeface: Fonts.Typeface;
	BEGIN
		typeface := Fonts.dir.Default()(HostFonts.Font).alias;
		Log.String(typeface); Log.Ln;
	END Do;


END ObxFonts.

luowy

[Zinn]

Another point is that I don't like two or more <br/> in series. It is better to use </p> and <p> instead.
- Helmut

[Josef Templ]

Another point is that I don't like two or more <br/> in series. It is better to use </p> and <p> instead.
- Helmut

And why?
If the BB text has multiple new lines in series why should that be translated into something different?

- Josef

[Josef Templ]

@Ivan: There is a bug in SetAttr.
I tried to read it but it is pretty hard to read. Then I made some experiments
and found a bug with the nesting of bold and italics.

aaabbbccc

Code: Select all

<p><b><i>aaa</b>bbb<b>ccc</i></b></p>

It can be seen that some tags are overlapping instead of nested.

My conclusion is that SetAttr needs to be polished.
It dropped some important comments and inserted empty lines instead. A bad deal.
It uses e.wr.Data for start and end tags but should use StartTag and EndTag instead.
The complex logic conditions need to be reformatted in order to make the nesting visible.
Fixing the bug should not add to the complexity but reduce it.

- Josef

[Zinn]

Another point is that I don't like two or more <br/> in series. It is better to use </p> and <p> instead.
- Helmut

And why?
If the BB text has multiple new lines in series why should that be translated into something different?

- Josef

It is a question about text formatting. Multiple spaces and new lines are ignored in Html.
In Html text formatting are not done with spaces and new lines. Text formatting are done with paragraph, list, tables and CSS.

Normally text are grouped in paragraph which allow to have line breaks but it is not grouped with line breaks. Line breaks should be used rarely.

The sample 1 2 3 What is Blackbox is translated wrong. A better translation uses list <li>, but I can accept line breaks here.
The original translation with paragraph is much better, even the result of the formatting looks wrong.

It is like the same situation as if you write a letter with the typewriter. There you have a line break at each line.
Now you change from typewriter to word and write the same letter. It is wrong to have a line break at the end of each line.

- Helmut

[Josef Templ]

Here is a corrected and (IMHO) polished version of SetAttr.
It solves the nesting bug.
It uses StartTag/EndTag.
It also adds support for strikeout.
By the way, was there a special reason for changing <em> to <i> and <strong> to <b>?

- Josef

Code: Select all

	PROCEDURE SetAttr (e: Exporter; newAttr: TextModels.Attributes);
	(* nesting: <p> <span> <b> <i> text </i> </b> </span> </p> *)
		CONST bold = (Fonts.normal + Fonts.bold) DIV 2;
		VAR s, tmp: ARRAY 256 OF CHAR;
	BEGIN
		ASSERT(e # NIL, 100);
		IF e.inPara & (e.attr # newAttr) & ((e.attr = NIL) OR (newAttr = NIL) OR ~e.attr.Equals(newAttr)) THEN
			IF e.attr # NIL THEN (* close all special attributes *)
				IF Fonts.italic IN e.attr.font.style THEN e.wr.EndTag(*i*) END;
				IF e.attr.font.weight >= bold THEN e.wr.EndTag(*b*) END;
			END;
			IF (newAttr = NIL) OR (e.attr = NIL)
			OR (e.attr.font.typeface # newAttr.font.typeface)
			OR (e.attr.font.size # newAttr.font.size)
			OR (e.attr.color # newAttr.color)
			OR (Fonts.underline IN newAttr.font.style / e.attr.font.style)
			OR (Fonts.strikeout IN newAttr.font.style / e.attr.font.style) THEN (* close span *)
				IF e.inSpan THEN e.wr.EndTag(*span*); e.inSpan := FALSE END
			END;
			IF (newAttr # NIL) & (~e.inSpan) THEN (* open span *)
				s := "";
				IF (newAttr.font.typeface # defaultTypeface) & (newAttr.font.typeface # Fonts.default) THEN
					s := "font-family: " + newAttr.font.typeface$ + ";"
				END;
				IF newAttr.color # Ports.defaultColor THEN
					IF s[0] # 0X THEN s := s + " " END;
					ColorToString(newAttr.color, tmp);
					s := s + "color: " + tmp + ";"
				END;
				IF newAttr.font.size # defaultSize THEN
					IF s[0] # 0X THEN s := s + " " END;
					Strings.IntToString(newAttr.font.size DIV Fonts.point, tmp);
					s := s + "font-size: " + tmp + "pt;"
				END;
				IF Fonts.underline IN newAttr.font.style THEN
					IF s[0] # 0X THEN s := s + " " END;
					IF Fonts.strikeout IN newAttr.font.style THEN s := s + "text-decoration: underline line-through;"
					ELSE s := s + "text-decoration: underline"
					END
				ELSIF Fonts.strikeout IN newAttr.font.style THEN
					IF s[0] # 0X THEN s := s + " " END;
					s := s + "text-decoration: line-through;"
				END;
				IF s[0] # 0X THEN
					e.wr.StartTag("span", XhtmlWriters.preserve); e.wr.Attr("style", s);
					e.inSpan := TRUE
				END
			END;
			IF newAttr # NIL THEN (* open all special attributes *)
				IF newAttr.font.weight >= bold THEN e.wr.StartTag("b", XhtmlWriters.preserve) END;
				IF Fonts.italic IN newAttr.font.style THEN e.wr.StartTag("i", XhtmlWriters.preserve) END
			END;
			e.attr := newAttr
		END
	END SetAttr;

StdCoder.Decode ..,, ..fq....3Qw7uP5PRPPNR9Rbf9b8R79FTvMf1GomCrlAy2xhX,Cb2x
hXhC6FU1xhiZiVBhihgmRiioedhgrZcZRiXFfaqmSrtuGfa4700zdGrr8rmCLLCJuyKtYcZRiX
7.2.s,6AP.0k,5TWyql.bnayKmKKqGomC5XzET1.PuP.MHT9N9ntumaU2,CJuyKtQC98P9PP7O
NbXmb.2.ojAk2Evm.,6.cUGpmWLuOpoKqvCbHZiYpedhA704TeKKw.bHfEWUmL.6..D.,716.C
cIhgsNHT9N9ntQ8qorG4704D.CbB,708T1U.EJe.T.3d02.,.X4,cU.ktAcoZimBhWhiohgnZc
ZRCY.2.w22U.EBU.U,.J7.tfj1.0E65.Q6AU0KyB.,..e,2.AU.Ue.4.072Ux.d51c6ERk.K.2
5A.EX4.162,E.0kE6.1606.H0y.0kfG.1M66.B5zT0VeITuE98FfeI986bONdPEd9RZ96FNNp7
698SVvPZ9R9fQr76RPNjPEd9RZfC,7J99Sd1m4ko.HtCPM0Fd8,dP9vQdPORvNp76t7Qx76ttQ
VPMRfD,7D3fD,7DHfD,7R99Sd96tt9HfD,7DTdMx76tt9b9Q1fPEsuHEemIqk2akVyIbCJe0Gl
yKqGKEqHEWGXyKrGrtuGryKtqqkmKEiGEOoru48qrmKmaGEGoYOJE8nRqk2aEf4Id0mtmGEGrq
0LR0mU8Jd4og0GNKHP0mbOIECIY4Idin4aEVKoXaIbqk2akUCpdKIdGJIKKECGEuoYmIK0mM0H
MamRqk2akYOIEKKLaKr0pk8rk0GH0GIKKL4KuGbUQYUohZ,aGEOGE2ZZp366v76ROGNO8,tHZ8
6FdP9vR..cT9f919RoZ3BipBggRicohZxCM8H76d8G9eHPM0akYUVVUQ2RWUYe6h6,78J7659P
TvQ99619PN96b9Q9vMHPMN9619Rdno.,d8HN1AV7A7Ooru4aKu4Kqaql0mYuIEKKLUiogjFLCL
uaLqKKEGJYkmwimpZ3phYZeVxgcIZdJZd2Y3pd2RbBAV7AV7A7KaV,UrhgdxgcZiUobx2YWxhg
76d8GUr,.3f8H7690kWuIWi1A7WGr.0mSUd.FNN..PM0Hkb8JEW0EL.dPSVPNBPM5PN,t6,dP9
1.YC.HN1HM0..UnBhuhgUQYUMN.UnVdgV7..sMT9PTfQ,t6,dP91.AZBA,U4xBCbpphYhgmZhd
phZ3Y7pdUohZxCEnELCLuUj2YZpZV,.kIqk2.UntQdfQHvO9vPf9R,NGR86..R,22...H76d0W
0.b9Q1HEe0M0HWZNOCJsEeWoWMNS5.QikBgiJZdQbUggiABEEenS0GX4IaCpW0mWuYBAV7AV3,
MG23.,t6u20GH0WyhgiAhi,H76d8G68whkhgi3Yn3iV76J,AVn3YugbUIYWQbBAV7M0H0.u06R
.007PNBPMf9Pd9Jn9QsMaGEOGEoB...00BuPQC7PNBPMfXd2YI37q.aUn,OqruahogVhhdZhtJ
bUIYUQZUohZ,.R,sMGGEiGE8mR8m4ak2AV3,M0HWihAUXlr220pr8LuCLLUplVyKqEeW2k2A7C
rh0ni0mF0GMWJEGJY66b96pNDCLEiGE8GE8GEKIbGoRU7sET9PTHeyqdGLtaKrSKIuqm..N76d
PPamRq.aUn,UXxhgFR0GF0mJYih3iUQZUsCU7g6.HMGoB.B1Cro66YAUHBhuFeW2P.HkYsQ.V,
66.EEMF.aUHZimBBCLLaIrGLeyqdG523..U2B7OorsQ0rraKrGLK0Guqad.aUn,UaxBqmtaKxK
KR0GFQ3666QdvC3N1HU7g6.HMGo6QCf1UU..Ui6R66d0P.HkYsQ..00.22K2U7MGo6QCb1L1..
Ui...UohgsN97PN5vPZPMdPOTfPp76ffP7PN.NPORPNP7RFfQTPRD9Ord6P.HkWmodKYn3Yu.L
,....8m4ak2A,9eHq.akWmY7pcUo6QC....u0.g,A,HWn,.66.EE.U7sQ.6R..EqaKrg3..HMF
RmRU7A7..M1M0KKLSLtQeoBgmZiIBgbd6b9Q1HFmGEWJoGrqmqf8roGrm8rtuGs8rmCrm8LvKq
IiHEKarlUGLu2ZWQioBD8GK0mtamRq.aUZNOR10GR6JZOJ9O1HM0akWM1.r,a2R1665Fb66EEW
0UVZhg,.MO..HMG.c9Ur,..MNkd.El8GK00...2Y3p7U7A7O2CbdZC...umtUU...ko8GK0Gg.
...g,g6.9nkG5,dCvFrKqvUBA,9WBMFRGECpmG5QbBIklbeZ3D5uPR9RZvPN9P9fQbndGb1Zim
Zh2hgnRg.AS..oZ1xhiZCU2hgnRg.sEMM.Et...ktu0.Y62UmX.2.Y02.A,,U..U,Iklb8IepZ
hZJinpZHFdKLq6F6.XDJ.QiiIepZhZ7F6.Zz.E.ses,sc6.,k,,UnpZHldG5GomCb.AS.c9Ajg
,0EtT.2.U6UOV.2.86.c918RABEWQC,E0E...7F.2U,2.2.2YXK90U.YjyC.zwP0k.k.E.0.3g
wPE.0U...p.0.4.IZ..,U.2m,.,.E4WDN.Ntarm3Wj.Jklb6.Qcj,.E6E...F.,.aU.Euqpt2Y
bQI,AzJE.nT3YyU3B,h8l2N.....
--- end of encoding ---