issue-#112 producing a change list from Redmine

User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

fixed.
I used a relative path instead of an absolute path when creating the file for redmine download.

I also added the conversion to html.
The resulting file is in the output directory, i.e. .../unstable/master (or if a final release in .../stable)
and follows the naming conventions of the other output files with a '_Changes.html' at the end.

I noticed that there are still conformance errors when checking with https://validator.w3.org.
The id of an anchor (from StdLinks.Target) must start with a letter. I fixed this locally in bbchanges.exe for testing.
Even with that fix there are some warnings regarding the doc type.

I will be travelling from tomorrow until Sunday and probably not be on the Internet much.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

Ivan can you please remove the bb.bak* directories from makeapp?
I don't have the permissions to do it myself.

And please don't forget: in order to get an up-to-date change list for a new build of master
the related redmine issue must be closed first, i.e. before merging to master.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

To remove folders in future you can first execute

Code: Select all

chmod 777 bb.bak -R
then you can remove

Code: Select all

rm bb.bak -R
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

Thanks.

The html changelist now is displayed under the name "New Page".
This shows that the title is not only redundant but misleading.
It should be removed in XhtmlExporter.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

I noticed occasional errors with cloning the repository in the build script.
Don't know what's going on. Therefore I introduced some test output in the script.

If it happens again I would like to look into it in more detail.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

The occasional errors when cloning the repository should now be eliminated.
The solution was to use option -q (for quiet) for cloning because otherwise
a progress report may be written to stderr, which is interpreted as an error message.

From my point of view this issue is finished and should be voted/merged.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

Josef, if you are already apply this and it's works well, is there any reason to make a vote?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

It is installed as a test on our Edis host but it is not yet merged into master.

Since any change in the repository needs to be reviewed (alias voted)
before it is merged with master, yes, we need a voting.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

I have fixed (or tried to fix) the wording of some of the issues in Redmine.
In particular, I fixed those that contained a discussion of possible solutions or
a solution that has not been applied as described in the issue:
#13, #21, #22, #96.

The changelist should now be easier to read and is not in contradiction with what has been
changed in the repository.

- Josef
Post Reply