Page 1 of 1
issue-#104 calling URLs and commands (revoting)
Posted: Thu Mar 17, 2016 4:02 am
by Ivan Denisov
This is NEW voting about issue-#104 (including
improvements made by Josef):
http://redmine.blackboxframework.org/issues/104
The discussion
We are voting for adding two new procedures
Dialog.Open for opening of files and URLs and
Dialog.Run to run external applications.
The realization with hooks is allowing easy to replace the realization for errors handling or for security issues.
Calling external applications will not break normal execution flow of BlackBox, because separate threads are used.
The suggested differences:
http://redmine.blackboxframework.org/pr ... 115335d51f
The BlackBox version for testing:
http://blackboxframework.org/unstable/i ... a1.455.zip
Re: issue-#104 calling URLs and commands (revoting)
Posted: Thu Mar 17, 2016 5:50 am
by DGDanforth
Works well for me. Both Run and Open.
-Doug
Re: issue-#104 calling URLs and commands (revoting)
Posted: Sat Mar 19, 2016 9:33 am
by Zinn
To the interface I vote yes
to the implementation I vote no
- Helmut
Re: issue-#104 calling URLs and commands (revoting)
Posted: Wed Mar 23, 2016 10:12 pm
by Zinn
I am sorry Ivan,
we must stop this voting again and go back to the design phase. The solution is not well-thought-out.
It is not possible to merge this current state to the master, because we get name discrepancy.
Dialog.Open via HostDialog.Open confuse with HostCmds.Open.
We should not use the name Open here and find another name.
To hurry make no sense.
- Helmut
Re: issue-#104 calling URLs and commands (revoting)
Posted: Thu Mar 24, 2016 3:53 am
by Ivan Denisov
Zinn wrote:I am sorry Ivan.
You should not excuse. If many members think that this issue can not be adopted, we should together think how to improve it.
That is normal process. This is one of the last features to add before beta version release.
However I will wait 2-3 days. Maybe some of the members will change opinion, because this issue is really ready for been adopted.
Dialog.Open does not confuse me or others except Helmut, so this is only serious argument for the delay.
Re: issue-#104 calling URLs and commands (revoting)
Posted: Thu Mar 24, 2016 6:50 am
by Josef Templ
I agree with Helmut's comment on the naming.
It should be renamed to OpenExternal.
But then also Run must be renamed to RunExternal. For symmetry!
Also the implementation of HostDialog.Start should be changed to
the way it was in BB 1.6. Exactly the same, not using Dialog.Run.
This procedure is for backwards compatibility and as such it should be unmodified.
Calling Dialog.Run instead would change its semantics because this is now
done asynchronously.
Until the changes are done I vote No.
- Josef
Re: issue-#104 calling URLs and commands (revoting)
Posted: Thu Mar 24, 2016 9:22 am
by Ivan Denisov
Now there is no uncertainty about the results of the voting
I am closing it.