oberoncore B8 HostMenus changes

[Josef Templ]

@Helmut, Ivan, oberoncore:
can anybody explain what the outstanding changes in HostMenus are about?

In the CPC change list there is under number 53 the following text:
Host/Mod/Menus
ert0devDeltasOSHMarker: Host/Mod/Menus, 20091011, TemirgaleevEE, B8

There are pending changes in PopupMenu and TranslateAccelerators.

What is the relation to CPC 37 (NextBox)?

- Josef

[Ivan Denisov]

It is already fixed in Center version (maybe it was fixed in 1.6 final).
http://forum.oberoncore.ru/viewtopic.php?f=116&t=1944

The bug had appeared if you was running BB from command line with long (> 80) arguments.

This is the fix in HostMenus.IncludingFileCommandLine:

Code: Select all

		NEW(l2, len + 1); 
		l2^ := line$;
		RETURN l2
	END IncludingFileCommandLine;

It was:

Code: Select all

	
		NEW(l2, len);
		FOR i := 0 TO len - 1 DO l2[i] := line[i] END;
	END IncludingFileCommandLine;

[Josef Templ]

Thanks, Ivan.

@Helmut: What about the pending changes in HostMenus.PopupMenu and HostMenus.TranslateAccelerators?

- Josef

[Zinn]

@Helmut: What about the pending changes in HostMenus.PopupMenu and HostMenus.TranslateAccelerators?

This change beyond to Koen Dessenger's NextBox. (CPC change number 37.)

● Standard popup menu and shortcut keys in Field, UpdownField
● Mouse wheel support for TimeField, Datefield, UpdownField, ComboBox

When working with edit fields on forms, Windows users expect some standard behavior. The commands "Undo", "Cut", "Copy", "Paste" and "Select All" can be issued via keybard shortcuts or a popup menu.

Moreover, if a menu is shown, items on it are enabled whether they are applicable or not. A special case is issuing "Cut" or "Copy" on a password field. Windows will show a nasty message after which the dialog cannot be immediately focused again.

1. Host/Mod/CFrames.odc
- 20111030, kd, support for native edit popupmenu and shortcut keys (* (1) *), (* (2) *), (* (3) *), (* (4) *), (* (5) *)
- 20111030, kd, make Edit|Delete work (* (1) *), (* (2) *), (* (3) *)
- 20111030, kd, UpdownField: Beep on invalid input (* (1) *), (* (2) *)
- 20111030, kd, Mouse Wheel support (* (1) *), (* (2) *), (* (3) *), (* 4) *), (* (5) *), (* (6) *)
- 20120315, kd, CreateUpDownControl
(http://msdn.microsoft.com/en-us/library ... 85%29.aspx)
- 20120317, kd, UpdownField: empty field is valid input (* (1) *)
- 20140320, Mathieu Westerweele, ListBoxes with horizontal scroll bars

2. Host/Mod/Cmds.odc
- 20111030, kd, PasteObjectGuard: disabled if focus is Control

3. Host/Mod/Menus.odc
- 20111030, kd, support for native edit popupmenu and shortcut keys (* (1) *)
- 20111030, kd, disable std popupmenu when clicking aux dialog surface in masked mode (* (2) *)
- 20111106, kd, added test for FormViews.View (* (2) *)

4. Std/Mod/Cmds.odc - not done !!! - change is canceled !!!
- 20111030, kd, SelectionGuard, PasteViewGuard, ShowPropGuard, ContainerGuard: disabled if focus is Control
I cancel this change , because we get a trap: 1. Start BB 2. Close Log Window 3. Open Edit Menu

5. System/Mod/Controls.odc
- 20111030, kd, support for native edit popupmenu and shortcut keys (* (1) *), (* (2) *), (* (3) *)
- 20111030, kd, ask frame if there is a selection for cut or copy, ask frame if selectable (* (1) *), (* (2) *), (* (3) *)
- 20111030, kd, disable cut/copy if f.password (* (1) *)
- 20111030, kd, Field, UpdownField: call f.Update after invalid input (* (1) *), (* (2) *)

[Josef Templ]

This is a complex change. I am not able to disentangle it into separate issues.
So I would create an issue named "improvements of Controls" with a list of included sub-issues
like the ones listed under number 37.
Any objections?

- Josef