issue-#85 Trap in DevDependencies with long module names

Locked

Should we merge the changes of topic branch issue-#85 to master?

Poll ended at Wed Nov 25, 2015 6:44 am

Yes
7
88%
No
1
13%
Abstain
0
No votes
 
Total votes: 8

Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

issue-#85 Trap in DevDependencies with long module names

Post by Zinn »

This voting is about merging the changes of topic branch issue-#85 (Trap in DevDependencies with long module names) to the master.

You can read more about this topic at http://forum.blackboxframework.org/view ... f=40&t=317

Gentlemen, please cast your vote.
- Helmut
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#85 Trap in DevDependencies with long module names

Post by Ivan Denisov »

Dear, Louwy and Chris. Why you are do not like this solution? Can you share your thoughts here, please?
luowy
Posts: 234
Joined: Mon Oct 20, 2014 12:52 pm

Re: issue-#85 Trap in DevDependencies with long module names

Post by luowy »

In fact, Jesof give a good solution,
I meant to select Yes,but I picked the No,sorry.
now Ivan remind me, after read the code for a while,I would like use "Extract" instead "Replace".

Code: Select all

PROCEDURE GetOpName(IN op, arg: ARRAY OF CHAR; VAR opName: Stores.OpName);
	VAR s: Stores.OpName;
BEGIN
	IF LEN(op$)+ LEN(arg$) +3 <LEN(Stores.OpName) THEN 
		s:=arg$;
	ELSE
		Strings.Extract(arg,0,LEN(Stores.OpName)-LEN(op$)-3-3-1,s);
		s:=s+'...';
	END;
	opName := op + ' "' + s + '"'; 
END GetOpName;
In fact,it is not wise, just my personal taste。

I have changed my Selection.
cfbsoftware
Posts: 204
Joined: Wed Sep 18, 2013 10:06 pm
Contact:

Re: issue-#85 Trap in DevDependencies with long module names

Post by cfbsoftware »

I have no interest in module names greater than 32 characters and would not want to condone their use. Or am I missing something?
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#85 Trap in DevDependencies with long module names

Post by Ivan Denisov »

cfbsoftware wrote:I have no interest in module names greater than 32 characters and would not want to condone their use. Or am I missing something?
I think, that this will not condone their use. However if somebody will use them, there will be better support for this.

The voting is over. The resulting version:
http://blackboxframework.org/unstable/m ... -setup.exe
http://blackboxframework.org/unstable/m ... a1.307.zip
Locked