issue-#85 Trap in DevDependencies with long module names
Posted: Fri Nov 06, 2015 11:02 am
Another issue with respect to avoiding a trap.
In DevDependencies there are undoable operations that contain the module name as part of the operation name,
which is defined as Stores.OpName = ARRAY 32 OF CHAR;
The solution proposed in CPC 1.7 rc5 is to enlarge Stores.OpName from 32 to 80 characters.
The side effect of this solution is that the undo/redo stacks then use about twice as much memory as before.
The obvious alternative is to shorten the resulting operation name in DevDependencies.
This would be a local change in a rarely used module as opposed to a global change in a very basic module (Stores)
I would actually prefer this latter variant. In addition, this change could be used for another little improvement:
The subsystem name or the module name in the operation name should be quoted in order to make it explicit that
it is an argument of the Expand resp. Collapse operation.
An Undo command for collapsing a module with a very long module name then would look like:
A similar approach is also used for example in 'Info -> Search In Sources', where the resulting Window is
shown in the Windows menu as:
For the issue see http://redmine.blackboxframework.org/issues/85.
For the variant with the local change in DevDependencies see http://redmine.blackboxframework.org/pr ... 71e8fed600.
- Josef
In DevDependencies there are undoable operations that contain the module name as part of the operation name,
which is defined as Stores.OpName = ARRAY 32 OF CHAR;
The solution proposed in CPC 1.7 rc5 is to enlarge Stores.OpName from 32 to 80 characters.
The side effect of this solution is that the undo/redo stacks then use about twice as much memory as before.
The obvious alternative is to shorten the resulting operation name in DevDependencies.
This would be a local change in a rarely used module as opposed to a global change in a very basic module (Stores)
I would actually prefer this latter variant. In addition, this change could be used for another little improvement:
The subsystem name or the module name in the operation name should be quoted in order to make it explicit that
it is an argument of the Expand resp. Collapse operation.
An Undo command for collapsing a module with a very long module name then would look like:
Code: Select all
Undo Collapse "VeryLongModuleName..."
shown in the Windows menu as:
Code: Select all
Search for "VeryLongSearchString..."
For the variant with the local change in DevDependencies see http://redmine.blackboxframework.org/pr ... 71e8fed600.
- Josef