As far as I see we have to do the same changes as in StdHeaders and Controls for
SqlControls and OleClient. This would mean to introduce a new version code,
to store in Unicode, and to load either the old or new version.
Also we have to extend Views.ReadFont/WriteFont
and TextModels.Attributes.Internalize/Externalize for
Unicode characters in a font name.
Strictly speaking, this would not be issue-#19 because it is not related
to Unicode support for CP identifiers but to Unicode support
for font names. Surprisingly, this was not an issue so far for the
cyrillic community. If it is not an issue, we can also skip this for now.
- Josef
issue-#19 Externalize & Internalize
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#19 Externalize & Internalize
I do not know fonts with non ASCII names so this is not a problem.Josef Templ wrote:As far as I see we have to do the same changes as in StdHeaders and Controls for
SqlControls and OleClient. This would mean to introduce a new version code,
to store in Unicode, and to load either the old or new version.
Also we have to extend Views.ReadFont/WriteFont
and TextModels.Attributes.Internalize/Externalize for
Unicode characters in a font name.
Strictly speaking, this would not be issue-#19 because it is not related
to Unicode support for CP identifiers but to Unicode support
for font names. Surprisingly, this was not an issue so far for the
cyrillic community. If it is not an issue, we can also skip this for now.
- Josef
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#19 Externalize & Internalize
I checked this before, notifiers and guards works well.Zinn wrote:Ivan,
please can you check that forms, guards and notifiers work with Cyrillic identifiers?
Thank you very much
- Helmut
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#19 Externalize & Internalize
Did you also check SqlControls?Ivan Denisov wrote:I checked this before, notifiers and guards works well.Zinn wrote:Ivan,
please can you check that forms, guards and notifiers work with Cyrillic identifiers?
Thank you very much
- Helmut
Probably not. It does not support Unicode yet.
- Josef
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#19 Externalize & Internalize
SqlControls and OleClient now also support Unicode.
SqlControls uses the same approach as was used in Controls.
OleClient uses Utf-8 conversion because it only stores CP identifiers in Model.link.
See the diffs at http://redmine.blackboxframework.org/pr ... 91f4951324.
- Josef
SqlControls uses the same approach as was used in Controls.
OleClient uses Utf-8 conversion because it only stores CP identifiers in Model.link.
See the diffs at http://redmine.blackboxframework.org/pr ... 91f4951324.
- Josef
Re: issue-#19 Externalize & Internalize
Is this topic ready for vote?
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#19 Externalize & Internalize
I think, yes. I did not check last Josef changes, however trust he did them well.Zinn wrote:Is this topic ready for vote?
Re: issue-#19 Externalize & Internalize
Josef's result works perfectly and is much better than my proposal here. I will prepare the vote soon.
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#19 Externalize & Internalize
From my point of view we are ready for voting.
- Josef
- Josef