Page 1 of 1

issue-#40 fixingconcatenation of Unicode character constants

Posted: Wed Apr 22, 2015 5:03 pm
by Josef Templ
similar to #39 this is a bug fix in the compiler. It lifts an accidental limitation
that disallows Unicode character constants to be concatenated.
See http://redmine.blackboxframework.org/issues/40.
The proposal by Luowy is well done and I have included the changes to the topic branch.

For the changes see http://redmine.blackboxframework.org/pr ... 8f663c42b9.

Since there is probably not much to discuss, I will create the voting immediately.

- Josef

Re: issue-#40 fixingconcatenation of Unicode character const

Posted: Thu Apr 23, 2015 10:35 pm
by cfbsoftware
Josef Templ wrote:It lifts an accidental limitation...
What evidence is there that it was accidental?

Re: issue-#40 fixingconcatenation of Unicode character const

Posted: Fri Apr 24, 2015 8:32 am
by Josef Templ
cfbsoftware wrote:
Josef Templ wrote:It lifts an accidental limitation...
What evidence is there that it was accidental?
The involved sequence of if-elsifs is rather complicated and there is a special
elsif for the concatenation operator further below. This special elsif is not executed because
another elsif is TRUE before and this applies only for Unicode character constants.
In addition, there is nothing in the language report that explains the difference between
concatenation of SHORTCHAR constants and Unicode constants.
The fix essentially skips the inappropriate elsif in case of concatentation
and allows the cascade to proceed until the elsif for the concatenation operator (+).

- Josef

Re: issue-#40 fixingconcatenation of Unicode character const

Posted: Mon Apr 27, 2015 7:10 am
by Josef Templ
I have locked the voting and merged the changes into master.

- Josef