Page 1 of 3
issue-#14.2 Tuning the build engine
Posted: Wed Apr 15, 2015 11:50 am
by Ivan Denisov
split from:
http://forum.blackboxframework.org/view ... f=40&t=205
Josef Templ wrote:The redmine replication and the build engine seem to be disabled.
Ivan, could you please check our Edis host?
I removed the folder "build", but forgot to update GitHub webhook. Now the hook works well:
http://blackboxframework.org/makeapp/githubhook.php
The server was restarted, so I need to run "xhost +" for Xvfb can start, but I found better solution. I already used this and try this in my server. However we need to fix the script a bit. I will do this in #38 branch.
Re: issue-#38 report passing receiver parameter IN to VAR
Posted: Wed Apr 15, 2015 12:17 pm
by Josef Templ
However we need to fix the script a bit. I will do this in #38 branch.
Stop, fixing the script has absolutely nothing to do with #38.
It cannot be combined. I know, it is tempting but we should really keep
separate issues separated.
- Josef
Re: issue-#38 report passing receiver parameter IN to VAR
Posted: Wed Apr 15, 2015 12:51 pm
by Ivan Denisov
Josef Templ wrote:However we need to fix the script a bit. I will do this in #38 branch.
Stop, fixing the script has absolutely nothing to do with #38.
It cannot be combined. I know, it is tempting but we should really keep
separate issues separated.
- Josef
Sorry, Josef, I
updated it already... We discussed this some time ago, that the support things, that do not require voting can be applied fast. Actually I forgot that this script (appbuild/build.py) not used for the CI directly... so I could just fix server script and did not touch the repository. I will try to do not repeat this mistake again. However I am also fix typo in README.
ALSO!!!
There was a problem with compatibly of
bbscript with commit 7c3f4d5b08c2d5b3919c6c889ddd5eeb4495fa28.
Code: Select all
compiling "Dialog" pos 26041, err 76
TRAP caught
So I manually to uploaded working bbscript.exe to the server for build machine can make master build
1.7-a1.096.
The problem is that
bbscript.exe is always changing after ANY branch is building...
The problem can be solved by keeping actual
bbscript.exe for each branch separately in different folders.
Re: Tuning the build engine
Posted: Thu Apr 16, 2015 10:19 am
by Josef Templ
> Sorry, Josef, I updated it already... We discussed this some time ago, that the support things, that do not require voting can be applied fast.
I can fix this easily in issue-#38.
The changes in build.py and the readme file could be
booked to issue-#14, so we don't have to create a new issue.
Whenever there is a change in the repository, this must be discussed and voted for.
If there is too detailed and specific content in the repository it should be moved to the Wiki.
This would allow us to make changes more quickly and in my opinion would be the correct handling
to the installation instructions in the readme file.
- Josef
Re: Tuning the build engine
Posted: Fri Apr 17, 2015 6:55 am
by Ivan Denisov
Do not remove installation instructions from README, please.
Re: Tuning the build engine
Posted: Wed Apr 29, 2015 1:22 pm
by Josef Templ
I have separated the changes related to the build engine and put them into issue-#14.
issue-#38 is without those changes now.
- Josef
Re: Tuning the build engine
Posted: Wed Apr 29, 2015 2:31 pm
by Ivan Denisov
The problem appeared again
During 122 build.
Code: Select all
new symbol file 16176 8
compiling "Dialog" pos 26041, err 76
TRAP caught
So this branch 38 made incompatible with master bbscript...
http://blackboxframework.org/unstable/issue-%2338/
Again I copied
bbscript from my local repository for it can perform build.
Re: Tuning the build engine
Posted: Mon May 04, 2015 8:01 am
by Josef Templ
Ivan, we need to find out what the underlying problem is.
Otherwise we may run into this problem again and again, which is
clearly not acceptable for an automated build engine.
When we understand the problem, we must fix the build script accordingly.
Unfortunately, I am out of office this week and cannot do much work on it.
- Josef
Re: Tuning the build engine
Posted: Fri May 08, 2015 2:50 pm
by Ivan Denisov
Exactly the problem is that we updated compiler in "master" branch. And this compiler is packed in bbscript.exe now, so when you try to compile old branches (for example #44), it cause TRAP. First TRAP in Dialog module in position 26041.
Code: Select all
PROCEDURE Exclude (IN t: Tree; node: TreeNode);
VAR c: TreeNode;
BEGIN
ASSERT(node # NIL, 20); ASSERT(node.tree = SYSTEM.ADR(t), 100);
IF t.Selected() = node THEN t.Select(NIL) >>> here <<< END;
node.tree := 0;
c := node.firstChild;
WHILE c # NIL DO Exclude(t, c); c := c.next END
END Exclude;
that is reasonable, because new compiler from master "does not like" modification of IN parameters...
The solution is simple: for each branch we should store bbscript.exe inside folder and use it for compile BlackBox of that branch.
This will prevent the situation when experimental compiler damage 'master' (branch #38 was damaging master) and 'master' will not damage 'issues' branches if in master the compiler was modified.
Also I have two improvements of Script subsystem.
1. Utf8 output for Script/Mod/Config.odc (for modules with unicode names)
2. Better AppendProperty (I developed it while making build engines for my projects)
Can I push this changes into some issue brunch or in the master? Do you trust me to tune engine while you a bit busy?
I really do not think, that we need to vote about this changes.
Re: Tuning the build engine
Posted: Sat May 09, 2015 8:10 am
by Josef Templ
Please push to issue-#14 then I can look into it.
In the commit message(s) please describe what the improvements are.
- Josef