issue-#37 fixing traps with long search patterns in DevSearc
Posted: Fri Apr 03, 2015 1:49 pm
Long search patterns lead to traps in DevSearch.
see http://redmine.blackboxframework.org/issues/37
A proposal for fixing this exists in CPC1.7 rc5, however it does not
solve the traps but only increases the pattern length from 64 to 128.
In addition CPC1.7 introduces a modification to DevSearch:
It writes the complete search pattern into the output window where the search result is listed.
I really don't like this very much because the search pattern is shown in the window title anyway.
It only makes a difference if the search pattern is a very long or multi-line text.
Technically, it is a trivial change but do we really need it?
In addition, the title creation needs to be refined anyway because it also leads to traps.
So, a simple approach would be to replace tabs and line feeds by spaces for the title
and to display as much of it as possible in the title.
This is the behavior of the current changes in the topic branch.
The current changes in the topic branch also extend the search pattern to 256
because this is what TextCmds.find.find supports anyway.
For the diffs please see: http://redmine.blackboxframework.org/pr ... 3797952210
- Josef
see http://redmine.blackboxframework.org/issues/37
A proposal for fixing this exists in CPC1.7 rc5, however it does not
solve the traps but only increases the pattern length from 64 to 128.
In addition CPC1.7 introduces a modification to DevSearch:
It writes the complete search pattern into the output window where the search result is listed.
I really don't like this very much because the search pattern is shown in the window title anyway.
It only makes a difference if the search pattern is a very long or multi-line text.
Technically, it is a trivial change but do we really need it?
In addition, the title creation needs to be refined anyway because it also leads to traps.
So, a simple approach would be to replace tabs and line feeds by spaces for the title
and to display as much of it as possible in the title.
This is the behavior of the current changes in the topic branch.
The current changes in the topic branch also extend the search pattern to 256
because this is what TextCmds.find.find supports anyway.
For the diffs please see: http://redmine.blackboxframework.org/pr ... 3797952210
- Josef