This voting is about merging the changes of topic branch issue-#33
(adding platform detection for wine, Windows 7, 8, cf. http://redmine.blackboxframework.org/issues/33)
to master. The diffs can be found under http://redmine.blackboxframework.org/pr ... 2b772f9d85.
Please note that this issue, in particular the wine detection, is independent from issue #32 (folds arrows display)
because it is a general purpose feature that can be used or not used in issue-#32
but may also be needed for other purposes not known so far.
Wine detection simply provides additional information if Dialog.IsWindows() returns true.
Dialog.platform was always part of BB and now also supports Windows 7 and 8 and
Dialog.IsWine() simply shows if Windows is emulated or run natively. Since there was no excessive abuse
of Dialog.platform in the past, there seems to be no danger that wine detection will be
abused in the future.
Gentlemen, please cast your vote.
- Josef
issue#-33 adding platform detection for wine, Windows 7, 8
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
issue#-33 adding platform detection for wine, Windows 7, 8
Last edited by Josef Templ on Wed Apr 15, 2015 8:06 am, edited 1 time in total.
- DGDanforth
- Posts: 1061
- Joined: Tue Sep 17, 2013 1:16 am
- Location: Palo Alto, California, USA
- Contact:
Re: issue#-33 adding platform detection for wine, Windows 7,
When Windows 10 is released this code will need to be modified to include it.
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue#-33 adding platform detection for wine, Windows 7,
When Windows 11 will be released it needs to be modified again and so on...
- Josef
- Josef
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue#-33 adding platform detection for wine, Windows 7,
In order to speed up the voting on issue-#33, I would like to
ask the missing center members again to cast their votes.
Those who voted No so far, please explain WHY you are against it.
Does it mean that Windows 7 and 8 detection should not be added
or is it about wine detection, for example?
This issue is a simple one and we should not get stuck with simple issues because
we have a lot more issues on our list.
- Josef
ask the missing center members again to cast their votes.
Those who voted No so far, please explain WHY you are against it.
Does it mean that Windows 7 and 8 detection should not be added
or is it about wine detection, for example?
This issue is a simple one and we should not get stuck with simple issues because
we have a lot more issues on our list.
- Josef
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue#-33 adding platform detection for wine, Windows 7,
I voted against adding wine detection now, because it can be used only in StdLinks and StdFolds, which have better solution. Also I do not like System layer growing by new functions IsWindows, IsLinux. In general the platform differences should be expressed in Host subsystem, not in the System modules.Josef Templ wrote:In order to speed up the voting on issue-#33, I would like to
ask the missing center members again to cast their votes.
Those who voted No so far, please explain WHY you are against it.
Does it mean that Windows 7 and 8 detection should not be added
or is it about wine detection, for example?
This issue is a simple one and we should not get stuck with simple issues because
we have a lot more issues on our list.
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue#-33 adding platform detection for wine, Windows 7,
There are still not enough votes.
Please cast your vote or Abstain.
Regarding Ivan's comment:
The auxiliary functions IsWindows etc. abstract from the underlying encoding
of the Dialog.platform numbers. It seemed better to use a function instead of
expressions like Dialog.platform DIV 10 = 1 in order to detect Windows.
And thereby we get the freedom to introduce any number e.g. for a new Windows
platform in the future.
Even if those functions are not used in BB itself because of changes to existing modules,
they may benefit outside users. After all, BB should not only used for compiling itself!
- Josef
Please cast your vote or Abstain.
Regarding Ivan's comment:
The auxiliary functions IsWindows etc. abstract from the underlying encoding
of the Dialog.platform numbers. It seemed better to use a function instead of
expressions like Dialog.platform DIV 10 = 1 in order to detect Windows.
And thereby we get the freedom to introduce any number e.g. for a new Windows
platform in the future.
Even if those functions are not used in BB itself because of changes to existing modules,
they may benefit outside users. After all, BB should not only used for compiling itself!
- Josef
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue#-33 adding platform detection for wine, Windows 7,
The voting is over now, and this branch can be merged.