Issue #16 - DevAnalyzer

Locked

Shall the Center adopt Josef's solution for the DevAnalyzer fix?

ABSTAIN
2
25%
YES
6
75%
NO
0
No votes
 
Total votes: 8

User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Issue #16 - DevAnalyzer

Post by DGDanforth »

A poll is now open to use the solution suggested by Josef to flag modification of an index variable.
The discussion of that issue is here
cfbsoftware
Posts: 204
Joined: Wed Sep 18, 2013 10:06 pm
Contact:

Re: Issue #16 - DevAnalyzer

Post by cfbsoftware »

In order to cast an informed vote I would like to see a precise definition of the bug - just a single code example that fails does not adequately document the nature of the problem. As a minimum, something on the lines of (assuming my understanding is correct):
DevAnalyzer in Blackbox 1.6 Final identifies when an index variable is modified within a FOR loop.

However in a very specific rare case it results in a trap:

1. There is a nested FOR loop

AND

2. The same index variable is used for each FOR loop

AND

3. The index variable is assigned to another variable within the FOR loop
If the fix solves other instance of traps then they should also be clearly identified. I would also like to see some evidence that regression testing has been done using other relevant code samples to ensure that the fix does not have any unwelcome side effects.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #16 - DevAnalyzer

Post by Ivan Denisov »

This voting is also finished.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue #16 - DevAnalyzer

Post by Josef Templ »

The fix covers only cases that failed before because there were INVALID,
i.e missing, labels in some CASE statements.
For anything else there is exactly the same behavior as before.
I have done some testing and I have not observed anything unexpected.

Of course, it would be nice to have an automated test suite that performs this
kind of regression testing. Unfortunately we don't have it now and it is not on the horizon.

For test cases see http://forum.blackboxframework.org/view ... f=40&t=101.

- Josef
Locked