BlackBox Framework Center

Josef Templ wrote:'ThisText' is not concerned with the distinction between source or docu or whatever kind of file.
It only needs to know if it should look at a language subdirectory.
Therefore it uses a parameter named useLang in the same way as it is done in StdApi.

'Search' on the other hand is called for two kinds of files, for sources and for docu.
Therefore it has a parameter named source and if set it uses Mod otherwise it uses Docu.
This has not been changed and it doesn't give much sense to change that.

- Josef

It just wasn't clear to me from the diff file that there were two different procedures being compared, "ThisText" and "Search", within the file Dev/Mod/Search.
Thank you for the clarification,

It seems that DevSearch.ThisText is not used by any other module so it is safe to modify the semantics of its BOOLEAN variable.
-Doug

ThisText is not exported, so it cannot be used anywhere else.

- Josef

Doug, please create a voting for this issue please.

Issue-#88 is now making search in sources language dependent. That is not good and Josef suggested the solution:
http://redmine.blackboxframework.org/pr ... 2db74b3ae8

Today I start proofing the master build 605.

Sorry, I found another bug in issue-#88.
The procedure Find in the module Dev/Mod/Search.odc uses 2 times the CAP function instead of the function Strings.Upper.

Further there should be a note in the documentation that a file in language directory is not used for the searching, when the file does not exist in the English directory. Workaround: Create an empty file in the English directory and the file in the language directory is searched.
The apposite way is not true. If a file doesn't exist in language directory then the file in English directory is used for searching.


- Helmut

Helmut, thanks for the reminder. This bug has been identified before, see
http://forum.blackboxframework.org/view ... +CAP#p3976
http://forum.blackboxframework.org/view ... +CAP#p4024.

Since I was not sure if it belongs to #88 I did not fix it before and then it has not been picked up again until now.
I looked at it again and didn' really find another more appropriate issue.
The bug appears mainly with localized documentation, so it seems to be OK to fix it under #88.

I also adapted the docu as you suggested.
For the changes see http://redmine.blackboxframework.org/pr ... 87783e090e.

- Josef

Can we proceed with this issue?