BlackBox Framework Center

Ivan Denisov wrote:I do not understand why Josef removed Meta from issue without any discussion.

Ivan, YOU introduced Meta in my version without any prior discussion!
Helmut and I have given you many reasons that show that
the existing guards are appropriate.
If there is any need, I can repeat the arguments in other words.
I can also add more arguments if required.

If the existing error messages are not sufficient,
this could of course be discussed.

- Josef

Josef Templ wrote:If the existing error messages are not sufficient,
this could of course be discussed.

I will explain the problem with more details. If you put some data to the link/notifier/guard field, the button will be activated. However if it is not module name, there will be silence if you push the button. That behavior is not acceptable. Something should happen if the button is active and you pushing it. I prefer the variant with disabled button if no module exists. So no error messages will be required and there will be syntax checking. The minimal realization is some error message like "Module not found". If you prefer to make error messages, it is ok.

Josef Templ wrote:Ivan, YOU introduced Meta in my version without any prior discussion!
Helmut and I have given you many reasons that show that
the existing guards are appropriate.
If there is any need, I can repeat the arguments in other words.
I can also add more arguments if required.

I was complaining that you remove my demo code even not trying to discuss. I make the demo for demonstration and discussion. The only feedback from Helmut is enough discussion for you? For me as a chairperson that is not enough. I want to here more opinions. This feature is changing the interface, so we should have some feedback from other Center members.

I find it slightly annoying when a control is disabled but the reason is not known.
I would prefer an error message.

-Doug

Ivan, these new buttons are TEXT SEARCH commands.
They have nothing to do with compiled code or modules being currently loaded.
By looking at the loaded modules in the guards you may get out of sync with the
source text but the commands are TEXT SEARCH commands and therefore
the guards must be simple and text based too. Otherwise you could create the
situation where the guard is disabled but the text search would succeed and vice versa.
Look at Info->Source and you will not find any complicated guard either.

I have used these commands for 19 years now and never felt the
need for any special guard at all (this was the first committed version).
With the added guards that look for empty strings it is still easy to understand why
the button is disabled. If you have no text selection then Info->Source also doesn't work.
So this current version is very much in line with Info->Source, a very simple
and well known BlackBox TEXT SEARCH command.

- Josef

This buttons are like Info -> Search in sources.... If nothing found you will get window with "No match found" message. So the similar message should be shown then nothing found with DevInspector dialog. It can be written to Log. However better to show error message with GetOk dialog.

I don't like OK Dialogs. I prefer an error message in the Log.
- Helmut

Ivan Denisov wrote:This buttons are like Info -> Search in sources.... If nothing found you will get window with "No match found" message. So the similar message should be shown then nothing found with DevInspector dialog. It can be written to Log. However better to show error message with GetOk dialog.

The new Inspector buttons are not like 'Info -> Search in sources...'
but like 'Info->Source'.

Anyway, errors are currently reported using Dialog.ShowParamStatus.
This could be changed to Dialog.ShowParamMsg.
Just looked it up for Info->Source and it is using Dialog.ShowParamMsg.
This change would better align the two commands.

- Josef

Josef, you saying that the error message currently is showing, but it does not.
Please, check by your self:
http://blackboxframework.org/unstable/i ... a1.428.zip
I think that all misunderstanding is because of this mismatch.

I tested it and the errors are displayed as expected.
Please check:
1. Do you see the status bar at the bottom of the BB window?
If it is disabled, there are no errors displayed because of using ShowParamStatus,
which only writes to the status bar.

2. If you have the status bar enabled, check the status bar for error messages.
Don't look at the Log.

As I mentioned before, I could easily switch to ShowParamMsg
in order to display the error messages also in the Log.
In addition, as I found out recently, this would be in line with
the error reporting used in Info->Source.

- Josef

Josef, you right. It was there! I did not mention these errors.
Please, switch to ShowParamMsg like Info->Source doing.