Page 3 of 3

Re: issue-#19 Externalize & Internalize

Posted: Mon Jul 13, 2015 9:34 am
by Josef Templ
As far as I see we have to do the same changes as in StdHeaders and Controls for
SqlControls and OleClient. This would mean to introduce a new version code,
to store in Unicode, and to load either the old or new version.

Also we have to extend Views.ReadFont/WriteFont
and TextModels.Attributes.Internalize/Externalize for
Unicode characters in a font name.
Strictly speaking, this would not be issue-#19 because it is not related
to Unicode support for CP identifiers but to Unicode support
for font names. Surprisingly, this was not an issue so far for the
cyrillic community. If it is not an issue, we can also skip this for now.

- Josef

Re: issue-#19 Externalize & Internalize

Posted: Mon Jul 13, 2015 9:54 am
by Ivan Denisov
Josef Templ wrote:As far as I see we have to do the same changes as in StdHeaders and Controls for
SqlControls and OleClient. This would mean to introduce a new version code,
to store in Unicode, and to load either the old or new version.

Also we have to extend Views.ReadFont/WriteFont
and TextModels.Attributes.Internalize/Externalize for
Unicode characters in a font name.
Strictly speaking, this would not be issue-#19 because it is not related
to Unicode support for CP identifiers but to Unicode support
for font names. Surprisingly, this was not an issue so far for the
cyrillic community. If it is not an issue, we can also skip this for now.

- Josef
I do not know fonts with non ASCII names :) so this is not a problem.

Re: issue-#19 Externalize & Internalize

Posted: Mon Jul 13, 2015 9:55 am
by Ivan Denisov
Zinn wrote:Ivan,
please can you check that forms, guards and notifiers work with Cyrillic identifiers?
Thank you very much
- Helmut
I checked this before, notifiers and guards works well.

Re: issue-#19 Externalize & Internalize

Posted: Mon Jul 13, 2015 10:49 am
by Josef Templ
Ivan Denisov wrote:
Zinn wrote:Ivan,
please can you check that forms, guards and notifiers work with Cyrillic identifiers?
Thank you very much
- Helmut
I checked this before, notifiers and guards works well.
Did you also check SqlControls?
Probably not. It does not support Unicode yet.

- Josef

Re: issue-#19 Externalize & Internalize

Posted: Tue Jul 14, 2015 5:57 am
by Josef Templ
SqlControls and OleClient now also support Unicode.

SqlControls uses the same approach as was used in Controls.
OleClient uses Utf-8 conversion because it only stores CP identifiers in Model.link.

See the diffs at http://redmine.blackboxframework.org/pr ... 91f4951324.

- Josef

Re: issue-#19 Externalize & Internalize

Posted: Fri Jul 17, 2015 7:38 am
by Zinn
Is this topic ready for vote?

Re: issue-#19 Externalize & Internalize

Posted: Sun Jul 19, 2015 5:10 am
by Ivan Denisov
Zinn wrote:Is this topic ready for vote?
I think, yes. I did not check last Josef changes, however trust he did them well.

Re: issue-#19 Externalize & Internalize

Posted: Sun Jul 19, 2015 6:13 am
by Zinn
Josef's result works perfectly and is much better than my proposal here. I will prepare the vote soon.

Re: issue-#19 Externalize & Internalize

Posted: Mon Jul 20, 2015 7:25 am
by Josef Templ
From my point of view we are ready for voting.

- Josef