Page 3 of 3

Re: issue-#44 unicode content of links&targets saving wrong

Posted: Fri May 08, 2015 1:57 pm
by Josef Templ
I have now looked more closely into the implementation and have
committed my proposal for the changes into issue-#44.

- elimination of version 0 reverted
- comment for version history added to Link:Externalize
- speed up of HasWideChars by common subexpression elimination
- Strings.Find avoided in Link:Externalize for version = 2
- small refactorings for reducing the amount of version specific code
- change list in chronological order as usual

I think the changes are in a good shape now. I have tested them with a number
of different test cases and found no problems so far.

Please have a look at the diffs at http://redmine.blackboxframework.org/pr ... 997bb3e11b.

or the overall diffs at http://redmine.blackboxframework.org/pr ... 4b15c28ec5.

- Josef

Re: issue-#44 unicode content of links&targets saving wrong

Posted: Fri May 08, 2015 5:16 pm
by Ivan Denisov
Works well. I am ready for voting :)

Re: issue-#44 unicode content of links&targets saving wrong

Posted: Sun May 10, 2015 2:44 pm
by Zinn
Josef, it is a very good solution!

Re: issue-#44 unicode content of links&targets saving wrong

Posted: Sun May 10, 2015 3:47 pm
by Josef Templ
Thanks for the votes. I have merged the changes.