Page 2 of 2
Re: issue-#111 code cleanups
Posted: Wed Apr 06, 2016 11:27 am
by Robert
Josef wrote: ... So I am not sure if this is a good idea.
As I understand it the language report does not allow the star. Other compilers (Gardens Point ?) could say that code that contains these stars is illegal. So this compiler should also reject the star.
It won't take long to find (and fix) modules that erroneously have the star.
Re: issue-#111 code cleanups
Posted: Fri Apr 08, 2016 3:03 am
by Ivan Denisov
Josef Templ wrote:
This is an undocumented feature of the compiler.
The star is silently ignored.
I cannot see any special case here.
It is simply a global unexported procedure.
Josef, does it really means nothing? In Astrobe such mark will switch off all safety checks inside such procedure, however it will increase speed. Chris called this leaf-procedure.
Re: issue-#111 code cleanups
Posted: Fri Apr 08, 2016 7:36 am
by Josef Templ
Whatever it means, it is not required in StdLog.
So I removed it from 4 procedures.
The feature is still in the compiler because otherwise we would get into troubles with
the build process. If it is removed from the compiler, it must not be used
in any of the other branches!
As far as I see the feature is silently ignored. See:
"IF sym = times THEN (* mode set later in DevCPB.CheckAssign *)"
Removing it from the compiler must be done later, if at all.
So, for now, I am ready to vote on this issue.
- Josef
Re: issue-#111 code cleanups
Posted: Fri Apr 08, 2016 8:28 am
by DGDanforth
Robert wrote:Josef wrote: ... So I am not sure if this is a good idea.
As I understand it the language report does not allow the star. Other compilers (Gardens Point ?) could say that code that contains these stars is illegal. So this compiler should also reject the star.
It won't take long to find (and fix) modules that erroneously have the star.
Search of all files within Mod subdirectories of Master 440 found only 1 module
StdLog
which had 4 procedures with the "*" marking.
-Doug
Re: issue-#111 code cleanups
Posted: Fri Apr 08, 2016 9:22 am
by Josef Templ
DGDanforth wrote:
Search of all files within Mod subdirectories of Master 440 found only 1 module
StdLog
which had 4 procedures with the "*" marking.
-Doug
I got the same search results.
Re: issue-#111 code cleanups
Posted: Tue Apr 12, 2016 5:25 pm
by Ivan Denisov
Ready for voting?
Re: issue-#111 code cleanups
Posted: Tue Apr 12, 2016 8:43 pm
by DGDanforth
Ivan Denisov wrote:Ready for voting?
Yes, as long as the "cleanup" is restricted as Josef has defined it.