Page 2 of 2
Re: issue-#98 improvements of GUI controls
Posted: Sat Jan 30, 2016 12:21 pm
by Josef Templ
Robert, thanks for the patience. Fixed.
Also I agree that the special case 'val = 0' with Ctrl+AU is not really needed.
One can click AU instead. So I have removed this case again.
The implementation is now following the docu.
For the changes see
http://redmine.blackboxframework.org/pr ... 80eee17aa9.
- Josef
Re: issue-#98 improvements of GUI controls
Posted: Sun Jan 31, 2016 9:47 am
by Robert
Josef Templ wrote:Also I agree that the special case 'val = 0' with Ctrl+AU is not really needed.
With this rationalisation, and by not clipping at the Control limits, the whole function simplfies to
Code: Select all
IF ch = AU THEN
IF ((f.min + 9) DIV 10 <= val) & (val <= f.max DIV 10) THEN val := val * 10 END
ELSE
IF val < 0 THEN INC(val, 9) END; val := val DIV 10
END
Re: issue-#98 improvements of GUI controls
Posted: Mon Feb 01, 2016 8:59 am
by Josef Templ
thanks, simplified.
See changes at:
http://redmine.blackboxframework.org/pr ... 71a1e69abf.
As an alternative to setting the max/min value by means of clipping at max/min I have added the <Shift> key for setting max/min directly.
- Josef
Re: issue-#98 improvements of GUI controls
Posted: Mon Feb 01, 2016 1:24 pm
by Josef Templ
typo fixed in Dev/Docu/Controls:
maximun => maximum.
- Josef
Re: issue-#98 improvements of GUI controls
Posted: Tue Feb 02, 2016 12:55 am
by Ivan Denisov
Robert, Josef, do all now is ready for voting?
Re: issue-#98 improvements of GUI controls
Posted: Tue Feb 02, 2016 8:35 am
by Josef Templ
For me this is ready for voting.
I have also looked into the two little things I left out from the CPC changes.
It is very clear for me now that they must not be done.
They don't solve a problem and they don't do it in the right way.
- Josef
Re: issue-#98 improvements of GUI controls
Posted: Tue Feb 02, 2016 8:45 am
by Robert
Ivan Denisov wrote:...ready for voting?
I think so.