StdApi.ThisMask

[Robert]

My memory has completely failed (too much Christmas celebration maybe?) I thought we had discussed these topics in the past, but these changes are not in 1.7.

The first issue is that when you use OpenAuxDialog or OpenToolDialog to open a Tab View an unwanted error message is posted. This is a 1 line fix I have been using since March 2009 - see the Violet code below.

The second issue is that when Form Views are loaded for use they are usually converted to Mask mode. However this does not apply to Forms on the tabs of a tab View.
The fix for this (which I have been using since January 2013) is in Magenta below.

Can anyone rememebr if this was discussed here before?

Code: Select all

	PROCEDURE ThisMask (param: ARRAY OF CHAR): Views.View;
		VAR v, tv, w: Views.View; c: Containers.Controller; rd: FormModels.Reader; k: INTEGER; label: Dialog.String;
	BEGIN
		v := ThisDialog(param);
		IF v # NIL THEN
			WITH v: Containers.View DO
				c := v.ThisController();
				IF c # NIL THEN
					c.SetOpts(c.opts - {Containers.noFocus} + {Containers.noCaret, Containers.noSelection});
					WITH c: FormControllers.Controller DO
						rd := c.form.NewReader (rd);
						LOOP
							rd.ReadView (tv);
							IF tv = NIL THEN EXIT END;
							WITH tv: StdTabViews.View DO
								FOR k := 0 TO tv.NofTabs() - 1 DO
									tv.GetItem(k, label, w);
									WITH w: Containers.View DO
										w.ThisController ().SetOpts(c.opts - {Containers.noFocus} + {Containers.noSelection,
											Containers.noCaret})
									ELSE
									END
								END
							ELSE
							END
						END
					ELSE
					END
				ELSE Dialog.ShowMsg("#System:NotEditable")
				END
			|	v: StdTabViews.View DO
			ELSE Dialog.ShowMsg("#System:ContainerExpected")
			END
		END;
		RETURN v
	END ThisMask

Code: Select all

StdCoder.Decode ..,, ..zT....3QwdONl9RhOO9vRbf9b8R7fJHPNGomCrlAyIhgs,CbKBhZ
 xi2,CoruKu4qouqm8rtuGfa4.hOO9vRb1Y66wb8RTfQ9vQRtIdvPZHWKqtCa.E.U5UAy.2U.Qk
 lbeZ3DPuP7PNNvQRtId9NPuP7X2hgnRAXDJ.QCPuP7PNG2sET1.PuP.MHT9N9nt.G2sIdvPZnt
 gcghghZcZRC8T0E.kiK.T.fO,2.,.bM.cU.ktAcoZimBhWhiohgnZcZRC.,.D,,6.I16.M.6.J
 Fyuv.U.2m,.101cUZj0E.6E2.c4E.yjz1,c8.0E.07M,kHk.a1AQAU0I.I5IU0Ky8U.2.m00.e
 ,2U.uz0U.2Ue.6.,6YUMU.gc.k,8Mtf.2..c4E.k.0.,c8.2UwK.c,E70.zT0VeITuE98FfeI9
 86d8OHvQPOMbvO,78VPMZPMPfC,NEZeI1OK,tHB8658G1eIHdC,dJHPNC5sCPM0HcJ1eI,dRN7
 6dfRN76jfC,dJHXn,iHECKR0mVyKrG5ICCoruKu8rrmKqKKtiHE8LmeHEOor8rqqorG4IeZBgY
 hgmR5LfC,NGR8J9uF9eIr76NPM3PNNfC,7FHPMNvPDf9b8RZPORvNrN18oWSoYuo4ak2OLEenS
 0GeW47OO19P2ZkBgmlIin4ak2aIX0Gv0mF0GbaIa0GeWoWuo4aU7we7Ze63YqJbUQcjlk.O30G
 Wyo4ak2ak2CKEenS0GvuGeWqoCrVyKrGLt.FN8rN1HU7A7CKECGEu2.M0CKLCpmGrb0LuCLICK
 LyKsGbUgZUQj1xhiNM.RvPBuP5PRbPT,t8,tS5uP.U1BgmhgoZZUQcjpB.sI99P9vMdPOTfPvP
 8rN1M0S3Qgu2Y4xBCoruam,CLLC2.0GWyo4k2cQ796pND,tMRdNTfQuGbKqv8pm4Km66FdQ7P8
 rN1M0YdDxdEhV7AV7A,ICRdI9PMOpoEIGLvamRqk2M0MGYiq3Yx2YCBdA,0mWWpYGJEKIbGoRq
 k2aU7UL,dfRp76b8R79J1fMhOO9nt.,7FU7.BuHZ86L96pND0HEGpb0GuOLLuorOKe4KlCLIaG
 EqGE4HEGobq.a.6Rhf9DONdPGdPNP98L99,7P1fMYZUwidQbBA,a.sJkveX1VV,o8.M0.jf9d8
 OH1IC.Hd9bONd1W0EE.AAUidF...kd.69PM0Hk2.QcjpB.sEkyam4ak2ak2.98HbOFPM0Hk2.9
 eH7O1HM0a.g6U7U3Z7U7U3p7k2MF.HkWm2k2gcC,akWm2,7FHPMc9WqrSraCrnWGFCmdartGrm
 qKRuorGrWGqoGrk8KqKKFam4ak2AV3p7EyaEveHEC3.C566.98H....sETfP.98SVPN59R99N3
 N8PM0cHkWsCcI98JfeIR86hP1HMFRGEGJoaaBVvgV0CyIhACoruam,CbHZiYRcoJigZcZRiX3U
 lb8..umV.EWKqtCK.Q6AAsQUm,..Unp3.6F6.Z50.G,0.aU.E..k.8ssH38pumqm8rtumdcIf9
 PY62Ulb8.CLL8pumqmY62UmT.6.QJw.QI2U.sU.ktumdsIdPSNPN7ONbvM,Mw.ELMSN12Um5,2
 ..FU.I92U.E,,.RNEdHtIAKa2V.6,6..UYU.AU.U.UUQoO7.,E.SoA5UTyB4.4.0E.cUZj0E..
 UO.,.1.eWUbl,.,6Y1.0..TK....
 --- end of encoding ---

[Zinn]

Robert please look at issue-#93 Opening a Form with a Tab View
http://forum.blackboxframework.org/view ... f=40&t=326
http://redmine.blackboxframework.org/issues/93
Votes: http://forum.blackboxframework.org/view ... f=56&t=350
- Helmut

[Robert]

Thanks Helmut; that makes more sense.

The second problem above has a better fix than the one I suggested, which is why I could not see my code in 1.7. I have not observed any problem here recently.

What I did observe today was the first problem above, which maybe we have not previously discussed here.

When a Tab View is loaded the Log receives the unwanted error message "container expected". The solution (I propose) is to add the single line

Code: Select all

			|	v: StdTabViews.View DO

to

Code: Select all

	PROCEDURE ThisMask (param: ARRAY OF CHAR; useLang: BOOLEAN): Views.View;
		VAR v: Views.View; c: Containers.Controller;
	BEGIN
		v := ThisDialog(param, useLang);
		IF v # NIL THEN
			WITH v: Containers.View DO
				c := v.ThisController();
				IF c # NIL THEN
					c.SetOpts(c.opts - {Containers.noFocus} + {Containers.noCaret, Containers.noSelection});
					IF modeHook # NIL THEN modeHook(c) END
				ELSE Dialog.ShowMsg("#System:NotEditable")
				END
			|	v: StdTabViews.View DO
			ELSE Dialog.ShowMsg("#System:ContainerExpected")
			END
		END;
		RETURN v
	END ThisMask;

[Josef Templ]

Robert, also the first issue has been discussed before.
See http://forum.blackboxframework.org/view ... t=10#p2885 where
you mentioned that it is not required.

"No, I guess it is not really necessary, and the error message to the Log is a very minor problem."

- Josef

[Robert]

I am currently moving some projects from (my slightly hacked version of) 1.6 to 1.7 (dated 31-Dec-2016).

This problem, which I had forgotten about, has resurfaced; I had added this extra line to my 1.6 version of ThisMask which is why I haven't been troubled by it.

I thought that a cleaner fix would be to simply put the TabView I use onto a Form of the same size.

Issue 1 - My code that finds the TabView no longer works; it finds the enclosing Form. This issue has a simple solution, and I only have to make the change in 1 place, so no problem.

Issue 2 - On the Tabs of the TabView are other Views that need to be Focus to operate correctly. But the enclosing Form is Focus, so these Views don't work. I can't see an easy solution to this.

Having these spurious error messages is unwelcome, so I am now thinking of raising this as a bug.

[Josef Templ]

If you use OpenAuxDialog or OpenToolDialog to open a view you normally
expect the view to be opened in "mask" mode.
If you do not expect it to be opened in mask mode would it be an option to open it with
OpenAux, for example?

Regarding the proposed fix:
Instead of adding special treatment for tab views for suppressing the error
message, it would be simpler and more general to remove the error message at all.
The docu allows this, I think.

- Josef

[Robert]

If you do not expect it to be opened in mask mode would it be an option to open it with
OpenAux, for example?

Thanks.
As far as I can tell this seems to be a perfectly satisfactory solution.
(The behaviour is different - the Window can be maximised - but this is of no consequence.)

My next question (my first as Chairman) is: "How do I move this thread to the resolved group?"

[Ivan Denisov]

My next question (my first as Chairman) is: "How do I move this thread to the resolved group?"

Robert, please sorry for the delay. I did not read carefully this part of your post previous time. Usually I am moderating the board. However if you want I can add you to the administrators group and you also will be able to moderate the board. Do you want to be a moderator?

[Robert]

Do you want to be a moderator?

I don't think so. I asked because I am trying to do my share of the work, but recognise that since different people have different amounts of time, differerent background knowledge, and different personal motivations, we won't all do equal shares of all tasks.

In this case it is probably easier for both of us if you move it, rather than teaching me how to move it.

Regarding the vote for "Interface change" Doug has sent me the directions you sent him about updating the git unstable version (assuming the vote passes). But I don't know how to create a voting form in phpBB. Do I need to be a moderator to do that? Are the instructions already published (maybe in the Wiki)?
I will try and do this in the next couple of days.

[Ivan Denisov]

You can create poll, just use the tab bellow the form of New Topic like I am showing in this picture