issue-#112 producing a change list from Redmine

User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

My understanding from the (very few) replies from the center is that a change list would be a good idea.
So I created an Infrastructure issue for that.

Regarding the Python versus BlackBox for downloading the xml file:
There is no value in proving that it can be done in BlackBox. This is clear anyway.
There is, however, a value in keeping things simple and avoiding dependencies on
ad-hoc external modules that we don't know in detail and that don't even have
a documentation. The simple solution is to insert a few lines of Python in the build script,
which is using Python anyway. It is hard to me to understand why there is a
discussion about that.

Remark: It is bad enough that we need the Xmlcore package,
not because it is a bad package but because it is external. Thereby it has the potential to
cause problems in the build engine if incompatible changes arise.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

It is better to make separate program for preparing this file. Xmlcore should not be included into the repository.

I think, we can provide both odc and html file in the download page.

Can you please post here your parcer, that generates odc from xml file.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

The changes so far are in issue-#112.

The change list is generated only when building master because
when building the issue the corresponding Redmine issue is typically not yet Closed,
so it would not be included anyway.

The format of the change list has been improved by adding a table of contents, i.e.
a list of features, docus, and bugs. The details follow behind.

Please see the example file under http://blackboxframework.org/unstable/i ... hanges.odc.
The file name contains the appVersion. This has the advantage that (1) it corresponds clearly with its contents and that (2) you see your BB version by looking in the root directory.
A fixed file name would also be possible of course. I am not completely sure what is better.

Currently there is no html version but this could be added.

@Ivan:
I have created a separate auxiliary program named bbchanges.exe that includes
the new module ScriptChanges, the Xmlcore subsystem, and the base BlackBox files needed.
This tool is not rebuilt automatically but must be built manually if there are any changes.
Thereby the tool is stable against any changes in the repository.
The tool is in the makeapp folder on the Edis host. The command for building the tool is in
ScriptChanges.

I have fixed a number of problems in build.py as described in the commit message.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

I like how you made this. Good work!

From my point of view html is required.
I tried to save this file as html and found a bug in Xhtml subsystem. Converter does not write end tags </body> and </html>
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

Ivan Denisov wrote:I like how you made this. Good work!

From my point of view html is required.
I tried to save this file as html and found a bug in Xhtml subsystem. Converter does not write end tags </body> and </html>
Thanks.

Xhtml has a problem with StdLinks.Target.
I have created the related bug issue.

Xhtml also cannot convert an external link into an html link.
This means that all the links to the Redmine issues are broken.

There are more problems with Xhtml but those are probably out-of-scope now.
The main problem is that a link (actually any view) must be outside any paragraph
leading to a separate line for each link.
This would need more work to analyze.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

Josef, there is some problem with downloading XML file

The built process stopped at
http://blackboxframework.org/unstable/logFile.html

Code: Select all

downloading xml files from Redmine
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

Thanks for the info. I looked into it.
When I test the build from the console it works.
When the build is done automatically it fails.
Something in the environment seems to be different.

I have to do more tests.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

Then it is building from environment www-data user is used.
So to check you need to run all commands with

Code: Select all

sudo -u www-data <command>
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#112 producing a change list from Redmine

Post by Josef Templ »

I tried to sudo but the error message is:
jtempl is not in the sudoers file. This incident will be reported.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#112 producing a change list from Redmine

Post by Ivan Denisov »

Josef Templ wrote:I tried to sudo but the error message is:
jtempl is not in the sudoers file. This incident will be reported.
Added you to sudoers. Please try again.
Post Reply