Issue-#175 Display StdLink command in status line

Merged to the master branch

Re: Issue-#175 Display StdLink command in status line

Postby Josef Templ » Sat Nov 11, 2017 9:29 am

Can we move further requirements to 1.7.2, please?

The current state is an improvement over the previous version, which we already agreed on.
Now it is not possible that a user is confused by accidentally open a link dialog.
Nobody will accidentally press Ctrl + mouse-right and be confused.
Also the mouse commands are much more systematic and easier to remember.

If you have a high-security requirement, don't put passwords into a link.
They can also be discovered by using a text editor on the document containing the link.

For me this is now ready for voting.
And after finishing the 'OpenExternal' issue we should really proceed with the release.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#175 Display StdLink command in status line

Postby Zinn » Sun Nov 12, 2017 10:31 am

yes, we can. I'm agree
- Helmut
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: Issue-#175 Display StdLink command in status line

Postby Zinn » Thu Nov 23, 2017 6:40 am

I just found a new introduced bug in StdLinks:
Ctrl-Click on link view expand the link view
but
Ctrl-Click on target view does not expand the target view
and
Target: is missing in the Rsrc/Strings file
- Helmut
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: Issue-#175 Display StdLink command in status line

Postby Josef Templ » Thu Nov 23, 2017 8:01 am

Zinn wrote:I just found a new introduced bug in StdLinks:
Ctrl-Click on link view expand the link view
but
Ctrl-Click on target view does not expand the target view
and
Target: is missing in the Rsrc/Strings file
- Helmut


Thanks for the careful testing.
There was indeed an asymmetry between Link and Target in HandleCtrlMsg.

It is fixed now. Just one line of code removed.

See diffs at https://redmine.blackboxframework.org/projects/blackbox/repository/diff?utf8=%E2%9C%93&rev=3f91e2baf48b03f6dcad752f5b9ab86d11f286c0&rev_to=e61d0bf94a05df46a50cc1f76cfe32500bf37a89.

> Target: is missing in the Rsrc/Strings file
Are you sure?
There are keys named 'Target' and 'Target:' in the Std/Rsrc/Strings file.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#175 Display StdLink command in status line

Postby Robert » Thu Nov 23, 2017 9:23 am

I suppose even this small correction requires another vote ... ?

I still have some questions in my mind over this issue.
1 - The intention is that using the Dialog is the suggested/recommended/main way of creating & editing Links & Targets.
2 - The special syntax was the main way, and is being kept for backward compatibility reasons.
3 - <Ctrl> Mouse-Left used to activate the main (only) way.
4 - <Ctrl> Mouse-Right now activates the main way.

I think there is an argument to exchange the roles of <Ctrl> Mouse-Right & <Ctrl> Mouse-Left.
And, if you did this, there would be more (better) compatibility between using the Link dialog and the StdStamps dialog, an advantage I have mentioned before.
User avatar
Robert
 
Posts: 1023
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#175 Display StdLink command in status line

Postby Zinn » Thu Nov 23, 2017 10:21 am

We don't need a vote. Nobody would like to have this error inside StdLinks. Unable to change the Target.

Ctrl-Mouse-Left expand the link view or target view to text.
Ctrl-Mouse-Right open the form for editing the link command or target name view.

What does the activates the main way mean?
- Helmut
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: Issue-#175 Display StdLink command in status line

Postby Robert » Thu Nov 23, 2017 11:28 am

Zinn wrote:What does the activates the main way mean?

Before this change the "main way" was to" expand the link view or target view to text."
After this change the main or preferred way is to "open the form for editing the link command or target name".

"Main way" has no formal definition, but is my understanding of how people would usually go about these tasks.
User avatar
Robert
 
Posts: 1023
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#175 Display StdLink command in status line

Postby Zinn » Thu Nov 23, 2017 4:50 pm

Sorry now we have another nasty bug. It is not possible position the cursor inside a target by clicking the left mouse bottom.
- Helmut
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: Issue-#175 Display StdLink command in status line

Postby Josef Templ » Fri Nov 24, 2017 8:26 am

Zinn wrote:Sorry now we have another nasty bug. It is not possible position the cursor inside a target by clicking the left mouse bottom.
- Helmut


The observed behavior resulted from treating Links and Targets in exactly the same way.
But I agree that this is questionable for Targets because
(1) it differs from the BB 1.7 behavior and
(2) there is no action associated with simple mouse clicks.
I have restored the BB 1.7 behavior for simple mouse clicks on Targets now.

See diffs at https://redmine.blackboxframework.org/projects/blackbox/repository/diff?utf8=%E2%9C%93&rev=2086fb6904ffb04553bda5bc86778e499372ecee&rev_to=3f91e2baf48b03f6dcad752f5b9ab86d11f286c0.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#175 Display StdLink command in status line

Postby Josef Templ » Fri Nov 24, 2017 8:35 am

Robert wrote:
Zinn wrote:What does the activates the main way mean?

Before this change the "main way" was to" expand the link view or target view to text."
After this change the main or preferred way is to "open the form for editing the link command or target name".

"Main way" has no formal definition, but is my understanding of how people would usually go about these tasks.


Since BB users are used to the old way of editing Links and Targets, it has been preserved.
This is for compatibility only; it is a strange way of editing properties.
If it had been removed, there would be an immediate request for
restoring the old behavior because it is a change that is not absolutely required.

After BB users get used to the new way of editing links and targets, the old style could be removed at all,
which would simplify the coding and the docu. Until that I would not change the mouse button assignment for the
old way. This would contradict the goal of being compatible.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

PreviousNext

Return to Resolved (Features)

Who is online

Users browsing this forum: No registered users and 1 guest

cron