Page 1 of 1

issue-#154 Atomic operation to get date and time

PostPosted: Mon Mar 13, 2017 4:25 pm
by Ivan Denisov
Ilya Ermakov found a critical issue: https://forum.oberoncore.ru/viewtopic.p ... 24#p100624

Module Dates has GetDate and GetTime procedures. However it does not have GetDateTime procedure.
There is the risk that at the boundary of the day application will get previous day but the time will be 00:00:00 except of 23:59:59. So there will be one day back.

To prevent such case in applications with critical safety there should be atomic operation for getting date and time.

There is the hook GetTime (OUT d: Date; OUT t: Time) for this operation, so realization of this issue is trivial:
https://redmine.blackboxframework.org/p ... 09ddc6ad20

BlackBox for testing new procedure Dates.GetDateTime:
http://blackboxframework.org/unstable/i ... a1.804.zip

Re: issue-#154 Atomic operation to get date and time

PostPosted: Mon Mar 13, 2017 9:01 pm
by Robert
Looks good to me.

Re: issue-#154 Atomic operation to get date and time

PostPosted: Tue Mar 14, 2017 12:53 pm
by Josef Templ
Looks good to me, too.

I would suggest to add the same also for UTC: "GetUTCDateTime".

For logging purposes, for example in the Http server, I have to use UTC
time because this is required for the log file format standard.
I think this is exactly what the issue is intended for.

- Josef

Re: issue-#154 Atomic operation to get date and time

PostPosted: Tue Mar 14, 2017 1:44 pm
by Ivan Denisov

Re: issue-#154 Atomic operation to get date and time

PostPosted: Tue Mar 14, 2017 2:23 pm
by Josef Templ
Thanks, for me this is ready for voting.

- Josef