Issue-#147 Fraction function in System Math

Merged to the master branch
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#147 Fraction function in System Math

Post by Robert »

Josef Templ wrote:It is sufficient to add an explanation of the alternative code such as:

"The following code shows how to implement a large part of the module Math
on top of a small set of basic functions and Component Pascal language features.
This may for example help to port the module to another platform."
Is it worth adding a warning that the domain of some of the alternative functions differs from the standard library - for example ArcTan2 (0., 0.)?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#147 Fraction function in System Math

Post by Josef Templ »

I have resolved the merge conflict now.
My approach to merge conflict resolution is a very primitive one.
I recreated the branch and took over all changes.

This avoids any advanced git features that I am not familiar with.
In addition it has another big advantage:
It simplifies the change history by avoiding multiple small commits and
intertwined git merges that make it hard to look at the changes of an issue
in master at a later time.

I made some very small refinements in the docu of Math.
Please review the changes at https://redmine.blackboxframework.org/p ... b7928bd3db.

The build is at http://blackboxframework.org/unstable/i ... a1.782.zip.


- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#147 Fraction function in System Math

Post by Robert »

Looks good to me.

I think we are now ready to have another vote.

I recently looked at the Chairman's responsibilities (https://wiki.blackboxframework.org/inde ... overned.3F), and I am meant to send emails to members about pending votes. Is this still necessary? Can it be automated?
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue-#147 Fraction function in System Math

Post by Ivan Denisov »

Robert wrote:I recently looked at the Chairman's responsibilities (https://wiki.blackboxframework.org/inde ... overned.3F), and I am meant to send emails to members about pending votes. Is this still necessary? Can it be automated?
Yes, it is.
GNotice.png
Post Reply