by Zinn » Wed Jan 11, 2017 9:15 am
Dear Ivan,
you have done a lot of work, but the result is not as easy readable as the original one.
For example when we read the line
ELSIF Kernel.err = 130 THEN LogWStr("Kernel.err.130")
then we don't know what is Kernel.err.130.
In the original module we read
ELSIF Kernel.err = 130 THEN out.WriteString("invalid CASE")
and we know immediently which error it is.
Why you don't change this line to
ELSIF Kernel.err = 130 THEN LogWStr("invalid CASE")
or
ELSIF Kernel.err = 130 THEN out.WriteString("#System:invalid CASE")
?
And I have another question: What is the reason to change the f.DrawLine in DevMarkers from
f.DrawLine(point, 0, w - 2 * point, h, 0, color);
f.DrawLine(w - 2 * point, 0, point, h, 0, color)
to
f.DrawLine(point, 0, w - f.dot, h, 0, color);
f.DrawLine(0, h + f.dot, w, - 2 * f.dot, 0, color)
?
- Helmut