issue-#142 adding a disassembler to the ocf importer

Merged to the master branch

Re: issue-#142 adding a disassembler to the ocf importer

Postby Josef Templ » Tue Dec 20, 2016 3:14 pm

I have fixed the utf-8 conversion for procedure names.

For the diffs see http://redmine.blackboxframework.org/projects/blackbox/repository/diff?utf8=%E2%9C%93&rev=f676c62a4faacc3c43ca2f8676fdabb291b9b0fb&rev_to=552e2201a78b5f8fe53b90f0188b2b38f8d9c26c.

I also removed unused constants in DevBrowser from issue-#140 that happend to
reappear after a manual merge conflict resolution.
(I also removed a couple of commented debug statements.)

I did not have time to look closely into the fixup chains.
(My first impression is that it is not easy to make the decoder
a symbolic disassembler that outputs symbolic names where possible.
It is also not easy to identify the places that may benefit from a comment like "fixup".
There is already a lot of symbolic information by means of merging the decoded instructions
with the source code. For understanding the output of the compiler's code generator this
is sufficient for me.)

- Josef




- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#142 adding a disassembler to the ocf importer

Postby Ivan Denisov » Fri Dec 23, 2016 6:37 pm

Checked this version:
http://blackboxframework.org/unstable/i ... a1.751.zip

Utf8 procedures are shown correctly now.
Attachments
cyrillic_procedure.png
cyrillic_procedure.png (8.45 KiB) Viewed 7835 times
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#142 adding a disassembler to the ocf importer

Postby Ivan Denisov » Fri Dec 23, 2016 6:41 pm

Josef Templ wrote:Instructions that need fixups can not be displayed "correctly" because the fixups are done
after loading the module. They refer to addresses only known at runtime, that's why
they need to be "fixed up" by the loader.
The only thing that may be possible in some cases is to add the target as a comment.
With the source merge feature, however, you see the target anyway from the source.


Can you please add this comment, that "this address is shifted by the fixup during the module load"? Or something like this...
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#142 adding a disassembler to the ocf importer

Postby Ivan Denisov » Thu Feb 23, 2017 9:13 am

Josef, do you think that this address problem does not require comments? There should be some documentation explanation anyway. DevDecoder386 does not have any documentation now!
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#142 adding a disassembler to the ocf importer

Postby Josef Templ » Mon Feb 27, 2017 10:12 am

The docu could be added to DevBrowser.ImportCodeFile.
BTW, the docu of DevBrowser.ShowCodeFile is inconsistent because ShowCodeFile
does not support filtering when a qualified identifier is selected.

By adding the docu to DevDecoder386 it will be hard to find for users.
However, a DevDecoder386 docu stub for "internal module" should be added indeed.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am


Re: issue-#142 adding a disassembler to the ocf importer

Postby Robert » Sat Mar 11, 2017 6:48 pm

It looks like we should vote on incorporating these changes.
User avatar
Robert
 
Posts: 1023
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#142 adding a disassembler to the ocf importer

Postby Ivan Denisov » Sun Mar 12, 2017 2:04 am

Robert wrote:It looks like we should vote on incorporating these changes.

Agree. With documentation it looks finished.
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#142 adding a disassembler to the ocf importer

Postby Robert » Mon Mar 13, 2017 9:12 pm

Does it make sense to vote on an issue that is not open? Do we need a new issue, or can this be reopened?

I'm not sure of the process here.
User avatar
Robert
 
Posts: 1023
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#142 adding a disassembler to the ocf importer

Postby Ivan Denisov » Tue Mar 14, 2017 4:56 am

Robert wrote:Does it make sense to vote on an issue that is not open? Do we need a new issue, or can this be reopened?

I'm not sure of the process here.

I think, we can reopen it before voting.

I changed status to resolved: https://redmine.blackboxframework.org/issues/142
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

PreviousNext

Return to Resolved (Features)

Who is online

Users browsing this forum: No registered users and 1 guest

cron