issue-#140 Unwrapping IMPORT aliasses

Merged to the master branch
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Josef Templ »

in addition the following lines should be removed from DevBrowser

Code: Select all

		(* additional scanner types *)
		import = 100; module = 101; semicolon = 102; becomes = 103; comEnd = 104;

- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

Josef Templ wrote:in addition the following lines should be removed from DevBrowser ...
Already spotted that!
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

I have incorporated Josef's improvements; for the Diffs see:

http://redmine.blackboxframework.org/pr ... 65730f0320
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

Josef Templ wrote:ResolveImport would also be my favorite.
I went for "ResolveImportAlias" before reading these posts. Does anyone object?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Josef Templ »

Robert wrote:
Josef Templ wrote:ResolveImport would also be my favorite.
I went for "ResolveImportAlias" before reading these posts. Does anyone object?
OK for me, even better.

> the enclosing Text's IMPORT statement.

better for me:
the enclosing module's IMPORT statement because it applies only when the
enclosing text is a module, i.e starts with the keyword MODULE.
(Or maybe Module's, i.e. with a capital M, you are the native speaker.)

It seems that you accidentally removed some menu files.

- Josef
Last edited by Josef Templ on Mon Nov 07, 2016 4:21 pm, edited 1 time in total.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

If anyone is wondering why I have just deleted three Menu files, I didn't do it deliberately.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

Josef Templ wrote:> the enclosing Text's IMPORT statement.
better for me:
the enclosing module's IMPORT statement.
I did this deliberately. The "selected module name" will always have an enclosing Text, which will sometimes (usually ?, but not always) be the source of a Module. Only in this latter case will there be a relevant IMPORT statement.
To say something that is precisely correct seemed to require more words that the slight ambiguity merits.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Josef Templ »

And the capital T of Text's? What is the rule behind it?
It is not a name, so why is it capitalized?

- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

My mistake.
I was thinking, without checking, that they were a name (in the sense that TextRulers have the type name "Ruler"). In fact the type name is "View" or "Model", which is not particularly informative here. So the imprecise English word "text" is the most suitable to use - imprecise in the sense that it is not defining the explicit BlackBox TYPE.

PS - Will (try to!) replace the missing Menus.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#140 Unwrapping IMPORT aliasses

Post by Robert »

Tried to recover the missing Menus locally, not sure if I've succeeded.
Can't push the current local state - see below:
git.exe push --progress "origin" issue-#140:issue-#140

To https://github.com/BlackBoxCenter/blackbox.git
! [rejected] issue-#140 -> issue-#140 (non-fast-forward)
error: failed to push some refs to 'https://github.com/BlackBoxCenter/blackbox.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

git did not exit cleanly (exit code 1) (2683 ms @ 07/11/2016 20:11:08)
I have updated the Docu's locally, so don't want to loose those changes.
Post Reply