issue-#111 code cleanups

Merged to the master branch
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#111 code cleanups

Post by Robert »

Josef wrote: ... So I am not sure if this is a good idea.
As I understand it the language report does not allow the star. Other compilers (Gardens Point ?) could say that code that contains these stars is illegal. So this compiler should also reject the star.

It won't take long to find (and fix) modules that erroneously have the star.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#111 code cleanups

Post by Ivan Denisov »

Josef Templ wrote: This is an undocumented feature of the compiler.
The star is silently ignored.
I cannot see any special case here.
It is simply a global unexported procedure.
Josef, does it really means nothing? In Astrobe such mark will switch off all safety checks inside such procedure, however it will increase speed. Chris called this leaf-procedure.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#111 code cleanups

Post by Josef Templ »

Whatever it means, it is not required in StdLog.
So I removed it from 4 procedures.

The feature is still in the compiler because otherwise we would get into troubles with
the build process. If it is removed from the compiler, it must not be used
in any of the other branches!

As far as I see the feature is silently ignored. See:
"IF sym = times THEN (* mode set later in DevCPB.CheckAssign *)"

Removing it from the compiler must be done later, if at all.
So, for now, I am ready to vote on this issue.

- Josef
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: issue-#111 code cleanups

Post by DGDanforth »

Robert wrote:
Josef wrote: ... So I am not sure if this is a good idea.
As I understand it the language report does not allow the star. Other compilers (Gardens Point ?) could say that code that contains these stars is illegal. So this compiler should also reject the star.

It won't take long to find (and fix) modules that erroneously have the star.
Search of all files within Mod subdirectories of Master 440 found only 1 module
StdLog
which had 4 procedures with the "*" marking.
-Doug
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#111 code cleanups

Post by Josef Templ »

DGDanforth wrote: Search of all files within Mod subdirectories of Master 440 found only 1 module
StdLog
which had 4 procedures with the "*" marking.
-Doug
I got the same search results.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#111 code cleanups

Post by Ivan Denisov »

Ready for voting?
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: issue-#111 code cleanups

Post by DGDanforth »

Ivan Denisov wrote:Ready for voting?
Yes, as long as the "cleanup" is restricted as Josef has defined it.
Post Reply