issue-#101 improvements for the std. properties inspector

Merged to the master branch
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#101 improvements for the std. properties inspecto

Post by Josef Templ »

The guards are now as proposed by Ivan, i.e. the buttons are disabled if the corresponding field is empty.
Also a label link button has been added.

here are the changes: http://redmine.blackboxframework.org/pr ... e894eb3631.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#101 improvements for the std. properties inspecto

Post by Ivan Denisov »

I was think not such simple check, but with Meta.Lookup.

I made some demo.
http://blackboxframework.org/unstable/i ... a1.426.zip
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#101 improvements for the std. properties inspecto

Post by Josef Templ »

Why do you want to make a more complicated check?
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#101 improvements for the std. properties inspecto

Post by Ivan Denisov »

Josef Templ wrote:Why do you want to make a more complicated check?
It is helping to check are the Notifier, Guard and Link procedures/variables existing.
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: issue-#101 improvements for the std. properties inspecto

Post by Zinn »

Ivan Denisov wrote:
Josef Templ wrote:Why do you want to make a more complicated check?
It is helping to check are the Notifier, Guard and Link procedures/variables existing.
No it doesn't help.
It might be possible that I would like to add a new Guard or a new Notifier.
Why should it not open the module via ... where I would like to insert them?
-Helmut
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#101 improvements for the std. properties inspecto

Post by Josef Templ »

Ivan Denisov wrote:
Josef Templ wrote:Why do you want to make a more complicated check?
It is helping to check are the Notifier, Guard and Link procedures/variables existing.
In some situations this might be very annoying.
If you make changes to the sources you would always have to recompile and reload
the module in order to work with Meta. Same problem if you have a new and incomplete module.

With the empty string approach you never depend on the code but only on the sources.
It is not only simpler to program but also simpler to use.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#101 improvements for the std. properties inspecto

Post by Josef Templ »

The button labels are now changed from '...' to '>'.
Also error messages have been added if Strings is not found or if the key is not found.
Meta has been removed.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#101 improvements for the std. properties inspecto

Post by Ivan Denisov »

I agree with Helmut, that the module can be opened even if the procedure does not exist. However the module should exists. This can be checked with Meta. I do not understand why Josef removed Meta from issue without any discussion.

Dear Center members, we need more attention and discussion here. According our rules if two members do not agree with me, they can ask to start voting without discussion. However I am sure this feature is touching the interface, so it should be discussed well.

Try with Meta check for Guards and Notifiers (the same can be made for Link):
http://blackboxframework.org/unstable/i ... a1.426.zip

Without check:
http://blackboxframework.org/unstable/i ... a1.428.zip

After Helmut comment I am suggesting some middle version with module existence check only.
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: issue-#101 improvements for the std. properties inspecto

Post by Zinn »

Guards and Notifier always called in the background and should not check if the file exist.
It will be better to stay at Josef's solution, because it is more efficient.
If an module doesn't exit, just write an error message to the log windows after clicking on [>] .
That is enough. We need no more checks.
- Helmut
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#101 improvements for the std. properties inspecto

Post by Ivan Denisov »

Zinn wrote:Guards and Notifier always called in the background and should not check if the file exist.
It will be better to stay at Josef's solution, because it is more efficient.
If an module doesn't exit, just write an error message to the log windows after clicking on [>] .
That is enough. We need no more checks.
So like in Control -> New form... dialog it should be message that module not found.
Post Reply