Robert, thanks for the patience. Fixed.
Also I agree that the special case 'val = 0' with Ctrl+AU is not really needed.
One can click AU instead. So I have removed this case again.
The implementation is now following the docu.
For the changes see http://redmine.blackboxframework.org/pr ... 80eee17aa9.
- Josef
issue-#98 improvements of GUI controls
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#98 improvements of GUI controls
With this rationalisation, and by not clipping at the Control limits, the whole function simplfies toJosef Templ wrote:Also I agree that the special case 'val = 0' with Ctrl+AU is not really needed.
Code: Select all
IF ch = AU THEN
IF ((f.min + 9) DIV 10 <= val) & (val <= f.max DIV 10) THEN val := val * 10 END
ELSE
IF val < 0 THEN INC(val, 9) END; val := val DIV 10
END
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#98 improvements of GUI controls
thanks, simplified.
See changes at: http://redmine.blackboxframework.org/pr ... 71a1e69abf.
As an alternative to setting the max/min value by means of clipping at max/min I have added the <Shift> key for setting max/min directly.
- Josef
See changes at: http://redmine.blackboxframework.org/pr ... 71a1e69abf.
As an alternative to setting the max/min value by means of clipping at max/min I have added the <Shift> key for setting max/min directly.
- Josef
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#98 improvements of GUI controls
typo fixed in Dev/Docu/Controls:
maximun => maximum.
- Josef
maximun => maximum.
- Josef
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#98 improvements of GUI controls
Robert, Josef, do all now is ready for voting?
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#98 improvements of GUI controls
For me this is ready for voting.
I have also looked into the two little things I left out from the CPC changes.
It is very clear for me now that they must not be done.
They don't solve a problem and they don't do it in the right way.
- Josef
I have also looked into the two little things I left out from the CPC changes.
It is very clear for me now that they must not be done.
They don't solve a problem and they don't do it in the right way.
- Josef
Re: issue-#98 improvements of GUI controls
I think so.Ivan Denisov wrote:...ready for voting?