issue-#90 adding horizontal scroll bar to list boxes

Merged to the master branch
Post Reply
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue-#90 adding horizontal scroll bar to list boxes

Post by Josef Templ »

This issue is for adding horizontal scroll bars to Lists and Selections.
For the issue see http://redmine.blackboxframework.org/issues/90.

The changes are mostly as proposed by Mathieu Westerweele in CPC 1.7 rc6 for SelectionBox.
The changes to CPC 1.7 rc6 are:
1. additional width of 5 pixels changed to Ports.point * 3 because then it is device independent.
2. the same changes are also applied to ListBox if not in drop-down mode.

For the changes see http://redmine.blackboxframework.org/pr ... 44888c2b98.

Plus: unused procedures ConvertFromUnicode and ConvertToUnicode removed.
This refers to another sub-entry in the CPC change list.

Remark:
When looking at the code I have seen that the list/selection box items are mapped by
Dialog.MapString. This was a big surprise for me.
Has anybody ever used this feature?
In my opinion, it is a mistake to map the contents of a control because it does not allow you to put arbitrary text in it.
The correct handling would be to call Dialog.MapString explicitly and only if needed before inserting with list.SetItem.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#90 adding horizontal scroll bar to list boxes

Post by Josef Templ »

Please review the changes regarding adding optional horizontal scrollbars and comment on it.
If there are no comments, we should vote on this.

Regarding my question on how to proceed with the usage of Dialog.MapString:
this can be ignored for now. It is not related to adding horizontal scrollbars but it
would be a separate issue.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#90 adding horizontal scroll bar to list boxes

Post by Josef Templ »

From my point of view this issue is ready for voting.

- Josef
Post Reply