issue-#60 underlining white space

[Josef Templ]

This issue is about decorating white space such as blanks or tabs
in BB text documents with the underline attribute. Technically, the underline
attribute will be handled in exactly the same way as the strikethrough attribute,
so this also applies to strikethrough.
For the issue see http://redmine.blackboxframework.org/issues/60.

It has been discussed informally if we need to introduce a flag in the Preferences Dialog
for users who don't want to use this feature and if we have such a flag what the default value
should be. See http://forum.blackboxframework.org/view ... ?f=41&t=86.

Most votes were against such a flag, one vote was in favor of a flag with the default set to non-underlined.
My question to Chris is if he has real problems with existing documents or BB based applications
that depend on the old behavior or if this is a general compatibility concern.

A possible approach would be to avoid the flag at the beginning and to add it later
if there is negative feedback from the user community.

CPC 1.7 rc5 contains my proposal for the changes plus a flag in the Preferences dialog by Helmut.
Me and my users use this feature since many years without any problems (and without a flag:-).

The changes so far without a flag are committed to issue-#60.
For the diffs see http://redmine.blackboxframework.org/pr ... d5dc7fee55.

- Josef

[Robert]

Please:

1 - Allow spaces to be underlined
2 - Do not have an option flag to control this.

I know this damages backward compatibility, but, in my opinion, the gain is more than the pain.

Regards

[Josef Templ]

... the gain is more than the pain.

I like the wording!

My personal feeling was always that this is more like a bug fix than a feature
and therefore it would justify inconveniences. I am not sure if in the real
world there are any problems to expect because it is a rarely used feature
among developers and students. Otherwise the users would have complained earlier.
But we must care for compatibility in general and therefore I am particularly
interested in Chris's comments about this.

- Josef

[Josef Templ]

I have posted a message in the community form regarding the community's opinion
about introducing underlined white space.

See http://community.blackboxframework.org/ ... p?f=3&t=93

- Josef

[Zinn]

Hello Josef

I checked your implementation of underline spaces and adapt the source of CPC edition to your version.
During this work I realized that I have forgotten to list the change of the file System/Docu/Ports in my documentation and it is also missing in your change here.
It is a good idea to delete the flag about switching on/off underline spaces.

Helmut

[Josef Templ]

Thanks, Helmut. I have adapted and added the System/Docu/Ports file.

For the other DrawXXX procedures there is an explicit precondition: font # NIL 20.
For DrawSpace I added:

Pre
font # NIL

I left out the trap number 20 here because it would not be consistent with the implementation.
The test is done implicitly in the WITH statement and yields a NIL trap.

- Josef

[Josef Templ]

I have found a place in ComDebug.ShowInterfaces where an unintended underline was used for a TAB.
This has been fixed. While testing the fix I noticed an update problem. The header line was not
updated when toggling between 'All' and 'New'. Since there was a trivial fix that actually simplified the source code,
I also included it.

For the changes see http://redmine.blackboxframework.org/pr ... 827f266d6e.

- Josef

[Josef Templ]

I think that this follow-up fix is also ready for voting.

- Josef