issue-#27 Adding SET conversion to Strings

Merged to the master branch
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue-#27 Adding SET conversion to Strings

Post by Josef Templ »

CPC 1.7 contains SET/ARRAY OF CHAR conversion for Component Pascal SET literals.
While there is no explicit change number for that, it is mentioned in number 2,
which roughly corresponds to our issue-#26 (docu fixes).
The proposal seems reasonable and I am definitely supporting it in principle.
We will have to look at the details, though.
We also have to add docu for it.

@Ivan: do you want to work on it? Or is there any other volunteer?
For other volunteers (Ivan already knows it) I can offer some help in getting you started with the
details of the development process. Helmut, what about you? Do you want to dig into git a bit?
My intention is really to get more center members involved because we have quite a large
list to work on and I certainly don't want to make it a one man show:-)

- Josef
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: issue-#27 Adding SET conversion to Strings

Post by Zinn »

Josef Templ wrote: Helmut, what about you? Do you want to dig into git a bit?
My old Windows Laptop is broken.

I have a new Laptop with Ubuntu 14.10 and no Windows.

The bbcb_1.6-1_i386.deb package from http://oberon.molpit.com doesn’t start BlackBox after installation on my Ubuntu.
I’m not familiar with Linux. I’m a novice user there.

I work with BlackBox under Wine 1.6 and I have some trouble there.
E.g.:
The Alt-Key doesn’t work inside BlackBox for setting attributes with the mouse.
Further Wingdings is not used inside Wine.

I have also access to one Desktop-PC with Windows 8.1, Office 2010, Internet Explorer and Firefox. There I can run BlackBox too. On this Desktop-PC I have no permission to install any other programs.

So how to start?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#27 Adding SET conversion to Strings

Post by Josef Templ »

> So how to start?

Start with the Win8.1 Desktop PC and install TortoiseGit
or get the admin to install it for you.
Follow the instructions in http://wiki.blackboxframework.org/index.php?title=Diff
for installing a diff viewer for .odc files.

If that is not possible don't start :-(
or install some Git client under Linux and configure a diff viewer
for it. Unfortunately, I cannot offer any detailed support for getting
this all started under Linux but I am pretty sure that it is possible.

- Josef
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: issue-#27 Adding SET conversion to Strings

Post by DGDanforth »

Josef Templ wrote: Start with the Win8.1 Desktop PC and install TortoiseGit
Josef,
I don't understand the need for having Git run on our machines.
Why not use the server's version of Git?
Just upload one's candidate module(s) to the server and have that Git handle them.

-Doug
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#27 Adding SET conversion to Strings

Post by Josef Templ »

Doug, what you need is a so-called 'git client', not a git server on your local machine.
Under Windows I recommend using TortoiseGit as the git client
because I know that it works well and it is convenient to use. Other git clients may work too.
The git client creates a clone of our github repository on your local machine.
Switch to the appropriate branch and edit the files locally. Later you use your git client for
committing the changes in your local repository clone and then to push the committed changes
back to our github topic branch.
This is the standard way of working with git. There may be other ways but more tricky
and less systematic.
It sounds complicated but it is really just a couple of mouse clicks and
some initial configuration and learning work.

- Josef
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: issue-#27 Adding SET conversion to Strings

Post by DGDanforth »

What I am suggesting is to use the EDIS machine as both server and client.
If only a single module is changed then it seems ridiculous to me to have to have all of the
files that Git is managing for BB reside on my machine. Just allocate a client space on
the EDIS machine (for each user that wishes to use Git), modify that one file and then
push it to the server Git.

I have only 1.9GB of space on my machine.

-Doug

Josef Templ wrote:Doug, what you need is a so-called 'git client', not a git server on your local machine.
Under Windows I recommend using TortoiseGit as the git client
because I know that it works well and it is convenient to use. Other git clients may work too.
The git client creates a clone of our github repository on your local machine.
Switch to the appropriate branch and edit the files locally. Later you use your git client for
committing the changes in your local repository clone and then to push the committed changes
back to our github topic branch.
This is the standard way of working with git. There may be other ways but more tricky
and less systematic.
It sounds complicated but it is really just a couple of mouse clicks and
some initial configuration and learning work.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#27 Adding SET conversion to Strings

Post by Ivan Denisov »

I agree with Doug, we have web-interface to look on any differences between branches!
For example: http://redmine.blackboxframework.org/pr ... 7561ad2777

But it is ok only if you just look and do not add any changes. If you want to execute the changes, the git software need to be used as said Josef.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#27 Adding SET conversion to Strings

Post by Ivan Denisov »

Josef Templ wrote:@Ivan: do you want to work on it? Or is there any other volunteer?
For other volunteers (Ivan already knows it) I can offer some help in getting you started with the
details of the development process. Helmut, what about you? Do you want to dig into git a bit?
My intention is really to get more center members involved because we have quite a large
list to work on and I certainly don't want to make it a one man show:-)
Josef, I am very busy now with main work, so I will avoid big efforts for few weeks. Later I am ready to execute some changes.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#27 Adding SET conversion to Strings

Post by Josef Templ »

> I have only 1.9GB of space on my machine.

Doug, it should be possible to use a USB memory stick.
You get plenty of space for a few dollars and you don't have to
switch to a new machine.

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#27 Adding SET conversion to Strings

Post by Josef Templ »

I have added topic branch issue-#27 as proposed in CPC 1.7 rc5.

There is one obvious issue with the proposal:
The values of res don't follow the conventions used in StringToInt and StringToReal.
res = 1 should be overflow and res = 2 should be syntax error.
It is exactly the other way round. This needs to be fixed.
In addition we need to add the specification to the docu.

I have added the required fixes and the missing spec in a separate commit.

Any comments?

- Josef
Post Reply