issue-#19: Unicode for Component Pascal identifiers

Merged to the master branch
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Issue #19: Unicode for Component Pascal identifiers

Post by DGDanforth »

Hmm,
When I voted for "Josef's solution" I was voting for using 16 bit CHAR for Component Pascal identifiers.
I was not voting for "converter".

To me the issue of what internal representation of 16 bit identifiers is handled is not important (can be hidden).
What is important is only that a full 16 bits are used for each character in an identifier. The high level goal is to allow identifiers to be written in all (most) of the world's languages.

I see that someone changed
"Issue #19: Unicode for Component Pascal identifiers" to
"Utf8ToString converter for Issue #19"

The second form is NOT what I voted on.
Ivan Denisov wrote: We voted just about converter. Doug, we need to make new voting!

- adopt Unicode for Component Pascal identifiers
- do not adopt Unicode for Component Pascal identifiers
- abstain
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #19: Unicode for Component Pascal identifiers

Post by Ivan Denisov »

Sorry, Doug, but you was careless in this case. Both Josef's and Luowe's solutions was about the same issue, so previous voting had no option "do not adopt Unicode for Component Pascal identifiers".

I hope, that others who not abstained had read my comment and voted about converter realization.
DGDanforth wrote:I see that someone changed
"Issue #19: Unicode for Component Pascal identifiers" to
"Utf8ToString converter for Issue #19"
Yes, I renamed the topic for you can create new voting with "Issue #19: Unicode for Component Pascal identifiers" title.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #19: Unicode for Component Pascal identifiers

Post by Ivan Denisov »

Josef, can you, please, merge the branches? Or you trust me to do this?
Also I think, that we can merge them without creating pull requests...
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue #19: Unicode for Component Pascal identifiers

Post by Josef Templ »

I have merged issue-#19 into master.

Regarding merging without pull request:
I don't know if that is possible, may be it is.
I have not seen anything in GitHub directly for doing it.
So it may require to merge it locally into master somehow
and to push the master changes.
This seems to be more complicated to do, but I really don't know.

The pull requests are fairly simple to generate from the GitHub web interface.
So the question is whether it would solve any known problems to avoid it.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: Issue #19: Unicode for Component Pascal identifiers

Post by Ivan Denisov »

The resulting versions:
http://blackboxframework.org/unstable/m ... a1.029.zip
http://blackboxframework.org/unstable/m ... -setup.exe

I am closing this topic. It is very long already.
Post Reply