issue-#13: DevCPT bug

Bernhard
Posts: 68
Joined: Tue Sep 17, 2013 6:56 am
Location: Munich, Germany

Re: #1 DevCPT bug

Post by Bernhard »

thanks Ivan, I still have to find my way around ...
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: #1 DevCPT bug

Post by Zinn »

In the source someone insert the comment
- 20140914, center, bug fix in FPrintHdFld and OutHdFld

Why you insert center and not your name?
Who is center?
Who have done this changes?

Which Name should be insert?
- Marco Ciot, who find the first solution
- or Chris Burrows, who improves the solution
- or "someone", who insert the changes in Redmine.
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: #1 DevCPT bug

Post by DGDanforth »

Zinn wrote:In the source someone insert the comment
- 20140914, center, bug fix in FPrintHdFld and OutHdFld

Why you insert center and not your name?
Who is center?
Who have done this changes?

Which Name should be insert?
- Marco Ciot, who find the first solution
- or Chris Burrows, who improves the solution
- or "someone", who insert the changes in Redmine.
I agree that who initiated the issue and whose solution should be included in Redmine.

Back in the good old days at Stanford we had an IBM 360 emulator running on our PDP-10 machine.
The code for the emulator was highly commented with the initials of each contributor to a change
indicated on a line-by-line basis.
-Doug
cfbsoftware
Posts: 204
Joined: Wed Sep 18, 2013 10:06 pm
Contact:

Re: #1 DevCPT bug

Post by cfbsoftware »

Normally, code changes should be signed by those who have accepted responsibility for the change. Hence, source changes that have been approved by a center vote should be attributed to all those who have voted in favour of the change. I would hope that anybody who hasn't taken any part in the solution(i.e. investigation, analysis, code changes, builds, testing, documentation and administration) abstains from voting.

However, it would be unwieldy to include all of the names who voted for a change so I support the use of the abbreviation 'center' for changes approved by a majority vote of the center. The relevant discussions and voting history should be kept so that anybody who does want investigate the reasoning behind a particular change, and the individuals who contributed towards the solution, can do so.
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: #1 DevCPT bug

Post by Ivan Denisov »

I agree, that we should include the person who find bug and who find final solution.

"Marco Ciot, Chris Burrows, ..."
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: #1 DevCPT bug

Post by Josef Templ »

Zinn wrote:In the source someone insert the comment
- 20140914, center, bug fix in FPrintHdFld and OutHdFld

Why you insert center and not your name?
Who is center?
Who have done this changes?

Which Name should be insert?
- Marco Ciot, who find the first solution
- or Chris Burrows, who improves the solution
- or "someone", who insert the changes in Redmine.
A one-line summary obviously cannot contain all the information.
'center' is the BlackBox Framework Center.
I didn't want to put my name into it because I only did the editing.
In principle the one-line summary could be removed at all, because the info is in Git/redmine anyway.
I inserted it in order to continue the tradition of listing the changes also inside a module.
For a module source file this is possible, for a docu or resource file it is not.
The decision to keep the tradition of the one-line summary inside module sources
should be discussed. There are advantages and disadvantages.

The names of the main contributors are mentioned in the related commit messages.
If you look at issue-#13 http://redmine.blackboxframework.org/issues/13
at the bottom right you find the related commits.

- Josef
Post Reply