issue-#145 add scanner option 'maskViews' in DevCommanders

Post Reply
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue-#145 add scanner option 'maskViews' in DevCommanders

Post by Josef Templ »

My users stumbled over an unintended side-effect of BlackBox 1.7 issue #103.
Therefore I have created https://redmine.blackboxframework.org/issues/145 for
removing the side-effect and returning the behavior of BB 1.6.

Here are the details:
BlackBox 1.6 treated a ruler (TextRulers.Ruler) that appeared in front of or as part of the command of a DevCommander as a paragraph character (0EX). With issue #103 of BlackBox 1.7 this behavior has been changed unintentionally and in 1.7 rulers are thereby returned as views (02X). This invalidates commands that contain a ruler or other masked views. The reason for the side effect is that option 'maskViews' was ignored in 1.6 but is honored in 1.7. By adding option 'maskViews' to the scanner used in DevCommanders the behavior of 1.6 can be re-established.

Note: this issue is not about undoing issue #103. It is only about undoing a side-effect
introduced by #103. The cases where it matters are admittedly rare but nevertheless
the problem showed up in a real-life situation and the fix is simple.
So I would propose to consider it.

Here are the diffs:
https://redmine.blackboxframework.org/p ... bd90a41bd0

I have also added the preferences (maskChar, hideable) to the TextRulers docu because this was undocumented so far.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#145 add scanner option 'maskViews' in DevCommande

Post by Ivan Denisov »

I think that this suggestion is reasonable.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#145 add scanner option 'maskViews' in DevCommande

Post by Josef Templ »

I have removed the changes in the docu of TextRulers.
Those changes are now handled in issue 146.

- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue-#145 add scanner option 'maskViews' in DevCommande

Post by Robert »

Should issue 145 be closed?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#145 add scanner option 'maskViews' in DevCommande

Post by Josef Templ »

No, please don't close it.
issue-#145 is ready for voting.

Here is the diff: https://redmine.blackboxframework.org/p ... bd90a41bd0

- Josef
Post Reply