issue-#132 Unwanted characters in the definition... Refs:#19

[Ivan Denisov]

http://redmine.blackboxframework.org/issues/132

[DGDanforth]

I can verify that

Code: Select all

DEFINITION Foo;

	TYPE
		Βασε = EXTENSIBLE RECORD  END;

		Εχτ = RECORD (Βασε 00X 懨 00X  00X ) END;

	PROCEDURE Do;

END Foo.

It appears there are 4 characters added.
-Doug

[Zinn]

It is a very strange error.
Change in the PROCEDURE ProperString (s: ARRAY OF SHORTCHAR); of MODULE DevBrowser;
the line
i := 0; WHILE (s # 0X) & (s # "^") DO global.out.WriteChar(str); INC(i) END
to
i := 0; WHILE (i < LEN(str$)) & (s # 0X) & (s # "^") DO global.out.WriteChar(str); INC(i) END
and it works.
Why does not work the compare s # 0X ?
- Helmut

[DGDanforth]

Partial answer.
SHORTCHAR can not hold a Uni char.

[Zinn]

Now I see the error. I must be blind.
The correct line is
i := 0; WHILE (str # 0X) & (str # "^") DO global.out.WriteChar(str); INC(i) END
Helmut

[Ivan Denisov]

I prepared testing version with Helmut fix.
http://blackboxframework.org/unstable/i ... .7.697.zip

Diff:
http://redmine.blackboxframework.org/pr ... 8bd250499c

[Josef Templ]

The fix looks fine to me.

Note: We also need to update appbuild/AppVersion.txt to "1.7.1-a1".

- Josef

[Ivan Denisov]

I have changed the app version

http://blackboxframework.org/unstable/i ... a1.698.zip

Doug, this issue is tested and ready for voting.

[Josef Templ]

agree

[DGDanforth]

Vote has been created.